Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources Page Table Layout Accessibility improvements #355

Closed
3 of 4 tasks
StephDriver opened this issue Apr 9, 2024 · 2 comments · Fixed by #409
Closed
3 of 4 tasks

Resources Page Table Layout Accessibility improvements #355

StephDriver opened this issue Apr 9, 2024 · 2 comments · Fixed by #409
Assignees
Labels
a11y accessibility

Comments

@StephDriver
Copy link
Contributor

StephDriver commented Apr 9, 2024

From #329

The Problem

on mobile, this ends up being too wide for the screen even though it changes column size, such that it cannot be read without scrolling the screen. This seems to be because there is a right side boarder to the white rectangular text block - that then requires the text block itself to be scrolled horizontally.

this may be more navigable with assistive tech if there was a row header cell defined (all row cells are currently td, no th except in the header itself). The first column: 'name', which is also a link to the resource in question and therefore unique would seem to be a good candidate for becoming a row header.

is this really a data-table within the meaning of the WCAG or is it a layout preference and so shouldn't be done as a table?

Tasks

  • is this a data-table or a layout preference? should table syntax even be used?
    • if table, then define the header cells for both rows and columns. Each item in the table should make sense if read as: "column header, row header, data cell". Without row and column header cells, this is not possible.
    • if not a table, then reformat without table syntax.
  • ensure new layout works on mobiles (narrow windows).
@StephDriver StephDriver added the a11y accessibility label Apr 9, 2024
@StephDriver StephDriver added this to the A11y actions from audit milestone Apr 10, 2024
@StephDriver
Copy link
Contributor Author

also review tables in https://www.openlibhums.org/plugins/supporters/site/library-partnership-fees/ for row & column headers.

@StephDriver StephDriver moved this to Triage in Accessibility Jun 4, 2024
@StephDriver StephDriver self-assigned this Nov 14, 2024
StephDriver added a commit that referenced this issue Nov 14, 2024
StephDriver added a commit that referenced this issue Nov 14, 2024
@StephDriver StephDriver moved this from Triage to Sent to Dev in Accessibility Nov 14, 2024
@StephDriver
Copy link
Contributor Author

also review tables in https://www.openlibhums.org/plugins/supporters/site/library-partnership-fees/ for row & column headers.

other tables are now being addressed in #410

StephDriver added a commit that referenced this issue Nov 15, 2024
StephDriver added a commit that referenced this issue Nov 15, 2024
ajrbyers pushed a commit that referenced this issue Nov 15, 2024
ajrbyers pushed a commit that referenced this issue Nov 15, 2024
ajrbyers pushed a commit that referenced this issue Nov 15, 2024
@github-project-automation github-project-automation bot moved this from Sent to Dev to Done in Accessibility Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y accessibility
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant