Server only receive first transform

[terajnol]

Hi all,

I am simply running the TrackerClient and ReceiveServer examples as described in the tutorial.
Port is set to 18944 and server to "localhost" (I run server and client on the same machine).

If I send X TransformMessage (or PositionMessage) from TrackerClient, I receive X messages to ReceiveServer but their values are all the same (value of the first message sent from TrackerClient). In the provided examples, TrackerClient is supposed to send a different transform matrix for each pack but ReceiveServer only gets the same matrix for each pack.

Sorry if this is really obvious, but I cannot figure out why I am always sending the same pack.
Thanks

[leochan2009]

Hi Terajnol,

Thanks for reporting the bug.
We just fixed the bug by initial the transformMessage before sending the pack.

Best,
Longquan

[terajnol]

Great !
I was just fixing it by creating a new TransformMessage object in the loop each time but InitPack() function is perfect.
Thanks for the fast fix !

[leochan2009]

Currently Only the following function will reset the m_IsBodyPacked flag:
SetDeviceName(), SetDeviceType(), SetHeaderVersion(), SetMessageID(), SetMetaDataElement().
In TransformMessage, SetMatrix() function won't reset the m_IsBodyPacked. User need to call InitPack before SetMatrix(), should we help the user by calling the InitPack() in SetMatrix()?
The same is for SetPosition() in PositionMessage and other message types.
@adamrankin @tokjun

Best,
Longquan.

[tokjun]

Sorry for not following this up. I'm not sure if it's a good idea to call InitPack() in SetMatrix(), because it would be confusing if the class resets the header whenever we set values in the content. Instead, I would just set the m_IsBodyPackedFlag to NULL whenever a new value is set in the content, which will trigger the packing process when Pack() is called.

[leochan2009]

@tokjun , please review the pull request. m_IsBodyPackedFlag is set to false when data is modified. Tests are also added

[tokjun]

@leochan2009 Thanks for fixing it quickly. They are looking good.