Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail under Fedora Rawhide with USE_SHARED_LIBS=ON #122

Open
mikhirev opened this issue Feb 26, 2017 · 2 comments
Open

Tests fail under Fedora Rawhide with USE_SHARED_LIBS=ON #122

mikhirev opened this issue Feb 26, 2017 · 2 comments

Comments

@mikhirev
Copy link

mikhirev commented Feb 26, 2017

When configured with -DUSE_SHARED_LIBS=ON, most tests fail under Fedora Rawhide (gcc 7.0.1). I was unable to capture/redirect extra output with exact error messages (invalid pointer, double free etc.) and memory maps.

I suppose, the problem is in gmock. From documentation:

Google Mock can be used as a DLL, but the same DLL must contain Google Test as well.

But there are separate libgtest.so, libgtest_main.so, libmock.so and libmock_main.so. Probably it is better to always link gmock and gtest statically to avoid this issue.

P. S. I removed igtl::Array<T>::GetValue() and igtl::Array<T>::SetValue() from igtlNDArrayMessage.h to get it built with gcc 7 (see #120).

leochan2009 added a commit to leochan2009/OpenIGTLink that referenced this issue Feb 27, 2017
@leochan2009
Copy link
Contributor

Thanks a lot !!!
Just made the google test a static build.
Now i am checking the travis and appveyor build results

leochan2009 added a commit to leochan2009/OpenIGTLink that referenced this issue Feb 27, 2017
leochan2009 added a commit to leochan2009/OpenIGTLink that referenced this issue Feb 27, 2017
@leochan2009
Copy link
Contributor

Hi mikhirev,
in my forked branch, i have made the google test a static build .
However, i still need to fix some compiler setting errors for windows OS,
you could take my fork repository at https://github.com/leochan2009/OpenIGTLink.git
branch: master.
Then the test error should be fixed.
I will come back to windows OS build issue ASAP,

Thanks a lot,
Longquan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants