Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack: doesn't preserve mtime #1

Closed
cyphar opened this issue Nov 5, 2016 · 2 comments
Closed

unpack: doesn't preserve mtime #1

cyphar opened this issue Nov 5, 2016 · 2 comments
Milestone

Comments

@cyphar
Copy link
Member

cyphar commented Nov 5, 2016

This is because the OCI tooling doesn't appear to handle this properly (image.CreateRuntimeLayoutBundle is to blame). It will probably be a good idea to from-scratch implement this feature inside umoci so that there is more than one implementation of this unpacking functionality.

% umoci unpack --image opensuse --ref latest --bundle bundle1
% sleep 30s
% umoci unpack --image opensuse --ref latest --bundle bundle2
% gomtree -f bundle1/*.mtree -p bundle2/rootfs >/dev/null
% echo $?
1

Where all of the gomtree failed keywords are related to time.

@cyphar
Copy link
Member Author

cyphar commented Nov 5, 2016

Opened a bug report upstream. opencontainers/image-tools#74

@cyphar
Copy link
Member Author

cyphar commented Nov 9, 2016

This has been fixed in 7654ebc. In addition, I dealt with the issue of . not having entries in most images (we just use the Unix epoch as the atime and mtime to make sure that bundles are completely consistent).

@cyphar cyphar closed this as completed Nov 9, 2016
@cyphar cyphar mentioned this issue Nov 9, 2016
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant