Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocm toi bootstrap package should support specifying ocmconfig on the command line #364

Open
dee0sap opened this issue Jan 9, 2025 · 0 comments
Labels
area/ipcei Important Project of Common European Interest kind/feature new feature, enhancement, improvement, extension

Comments

@dee0sap
Copy link

dee0sap commented Jan 9, 2025

What would you like to be added:

Here are the flags for ocm toi bootstrap package :

   --config stringToString   driver config (default [])
  -C, --create-env string       create local filesystem contract to call executor command locally
  -c, --credentials string      credentials file
  -h, --help                    help for package
      --lookup stringArray      repository name or spec for closure lookup fallback
  -o, --outputs string          output file/directory
  -p, --parameters string       parameter file
      --repo string             repository name or spec

While there is a --config flag it is for the driver, i.e. docker, and not for ocm itself. So to specify a config file you need to run ocm like so

HOME=/home/dsmall/git-repos/ocm-toi-helloworld/userInput ocm toi bootstrap package ...

With other commands you can use --config to specify the location of the ocmconfig.

I recommend that we add --ocmconfig for the location of the ocmconfig so that backwards combability is maintained

Why is this needed:

Because overriding HOME could have side effects.

Also, as it stand if the TOI installer requires credentials that are actually in a repository such as Vault, you need to provide both a credentials file and an ocmconfig file. You aren't able to just provide a credentials file. ( I'll create another ticket for this )

@dee0sap dee0sap added the kind/feature new feature, enhancement, improvement, extension label Jan 9, 2025
@github-actions github-actions bot added the area/ipcei Important Project of Common European Interest label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ipcei Important Project of Common European Interest kind/feature new feature, enhancement, improvement, extension
Projects
Status: 🆕 ToDo
Development

No branches or pull requests

1 participant