Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content-Types - binary Accept header and v1 JSON type #22

Open
harmanpa opened this issue Jan 14, 2020 · 0 comments
Open

Content-Types - binary Accept header and v1 JSON type #22

harmanpa opened this issue Jan 14, 2020 · 0 comments
Assignees
@harmanpa

Comments

@harmanpa
Copy link
Collaborator

The client was previously changed to only support deserializing application/vnd.onshape.v2+json Content-Types, however application/vnd.onshape.v1+json is still used as a header for some responses, notably empty responses from delete methods. Both should be considered.

The client currently uses an Accept header of application/vnd.onshape.v2+octet-stream for download responses, however some methods such as PartStudios.exportParasolid() now give a 406 response to this.
@harmanpa harmanpa self-assigned this Jan 14, 2020
harmanpa added a commit to harmanpa/api-generator that referenced this issue Jan 14, 2020
@harmanpa
Correctly create entity containing Blob for file uploads (see onshape…
51dadd5 
…-public/java-client#21), also set fileContentLength field based on blob size.

Re-add support for Onshape v1 JSON format as sometimes used on empty responses, and send array of acceptable response types, including "*/*" in the case of binary responses (see onshape-public/java-client#22).
@harmanpa harmanpa mentioned this issue Jan 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harmanpa harmanpa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harmanpa