Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outstanding issues related to standalone mode #512

Open
21 of 27 tasks
AjBreidenbach opened this issue Jun 20, 2024 · 3 comments
Open
21 of 27 tasks

Outstanding issues related to standalone mode #512

AjBreidenbach opened this issue Jun 20, 2024 · 3 comments

Comments

@AjBreidenbach
Copy link
Member

AjBreidenbach commented Jun 20, 2024

Outstanding Issues and Bugs

  • Re-enable the "search" filter box on the dashboard's pivot table. (it only shows up when there's at least 2 rows)
  • Remove or replace non-relevant columns (e.g., merge requests, auto-stop scheduled) in the deployments view for local mode.
  • Don't assume project path is for a repository on the cloud server (i.e., unfurl.cloud)
  • Include deployments not in an environment (add defaults as an environment), especially the default one created by init.
  • Fetch types from cloudmap when no repositories are defined in the dashboard (assume std).
  • Don't display the hello message when the dashboard is empty.
  • Don't make a call for /api/v4/projects/<path:project_path>
  • Existing deployment paths are broken if they have a unique location
  • Do not send undefined for latest commit
  • rename deployment doesn't appear to work (now disabled when no deployment blueprint)

Areas to Validate or Reproduce

  • Empty modal issue with the spinner at http://localhost:8081/#new-deployment. (error now explains that no valid blueprints could be found)
  • Confirm items created with unfurl init are displayed correctly.
  • Test with a dashboard containing both local and remote environments.
  • Check the application links for proper URL patterns and functionality.
  • Ensure serve_document function correctly serves the dashboard or application based on URL pattern for the served project.
  • Test with no remote, remote on unfurl.cloud
  • Test remote with ssh git URL on foreign git server.
  • Test with --mono repos and split repo (the default where the deployment ensemble is in a separate repo).
  • Verify credentials aren't sent to wrong origin
  • Verify applications with branches other than main work as intended

Unimplemented

  • Use cloudmap project avatar when none set in blueprint export
  • Adjust links in the application column to correctly display the blueprint overview when applicable.
  • Automatically install the correct version of unfurl-gui from GitHub release in the absence of UNFURL_GUI_DIR. (implementation needs discussion)
  • Use GitLab environment CI variables as backend for standalone when the project has an unfurl.cloud instance upstream.
  • Do not make any API calls for an application without a defined projectPath.
  • Only use credentials for repositories on the same origin. (credentials aren't handled by frontend anymore)
  • Don't patch variables for vault password / subscriptions

updated to reflect #512 (comment)

@AjBreidenbach
Copy link
Member Author

Planned features and test coverage are documented here https://docs.google.com/spreadsheets/d/1GItSpQ9eoJcqnUvPSsrt4669QeDoqxilKnJwp65tk2c/edit?usp=sharing

@aszs
Copy link
Member

aszs commented Jun 20, 2024

  • don't assume project path is for a repository on the cloud server (i.e. unfurl.cloud)
  • test with no remote, remote on unfurl.cloud, remote with ssh git url on foreign git server
  • test with --mono repos and split repo (the default where the deployment ensemble is in a separate repo)
  • include deployments not in a environment (add defaults as an environment), especially the default one created by init
  • don't display the hello message when dashboard is empty

@AjBreidenbach
Copy link
Member Author

I have checked off Don't assume project path is for a repository on the cloud server (i.e., unfurl.cloud)
I think it's fixed because of the local: prefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants