Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile required Python and R packages not already in the images #4

Open
emiliom opened this issue Feb 3, 2023 · 10 comments
Open

Compile required Python and R packages not already in the images #4

emiliom opened this issue Feb 3, 2023 · 10 comments
Labels
ohw23es-intercoonecta Feb - Mar 2023 event in Spanish

Comments

@emiliom
Copy link
Member

emiliom commented Feb 3, 2023

I'll start communicating with the OHWes team to identify required packages.

In the meantime, for reference and as a guide, here are the issues @abkfenris created for OHW22 for this task:

@emiliom emiliom added the ohw23es-intercoonecta Feb - Mar 2023 event in Spanish label Feb 3, 2023
@emiliom
Copy link
Member Author

emiliom commented Feb 21, 2023

@abkfenris for the R image, do the R packages have to be conda packages? The conda lock file suggests that's the case, but the exchanges in oceanhackweek/jupyter-image#49 suggest otherwise.

@abkfenris
Copy link
Contributor

abkfenris commented Feb 21, 2023

They don't have to be. For direct CRAN installs they can go into the Dockerfile: https://github.com/oceanhackweek/jupyter-image/blob/082c6937faaddf66b07311a96ebb1ed1670cff24/r/Dockerfile#L78-L93

The problem with that method is that errors are silently ignored during the build so Ben was playing with setting up a more generalized install script that could catch errors and fail appropriately.

@emiliom
Copy link
Member Author

emiliom commented Feb 21, 2023

Ah, I wasn't aware of that mechanism. Thanks. We'll watch out for silent errors.

@emiliom
Copy link
Member Author

emiliom commented Feb 24, 2023

Just for reference: I'm compiling the additional packages in Intercoonecta/tutoriales#1. But that's all in Spanish, plus I'll handle all the image updates.

@emiliom
Copy link
Member Author

emiliom commented Feb 24, 2023

@abkfenris For CRAN and github R package additions, the statements in the Dockerfile include the following arguments, with the values being the same (FALSE) for all packages:

dependencies=FALSE, upgrade_dependencies=FALSE, upgrade=FALSE

One of the packages I'm adding is from github, and the tutorial presenter is the developer. He asked me to include its dependencies. Should I set dependencies=TRUE? Or are dependencies installed despite the argument dependencies=FALSE?

@abkfenris
Copy link
Contributor

Dependencies should either be added manually via conda-forge or in the Dockerfile, so it takes a little work to figure out everything to add.

R is bad about respecting dependencies that are already installed and then gets angry that there are multiple sources of dependencies. Ben was working on a script to try to play nicer (and fail appropriately), but I'm not sure what happened to it.

@emiliom
Copy link
Member Author

emiliom commented Feb 24, 2023

I had a bad bunch hunch that was the case. Thanks. I'll do that.

(I don't know what having a bad bunch is, unless I was referring to a bunch of packages 🙄)

@emiliom
Copy link
Member Author

emiliom commented Feb 24, 2023

For reference, at least for the R package on github that I'm handling, the dependencies are listed in the DESCRIPTION files, under Imports:.

@emiliom
Copy link
Member Author

emiliom commented Feb 24, 2023

I've created two image updates: Python (PR oceanhackweek/jupyter-image#64) and R (PR oceanhackweek/jupyter-image#65).

@emiliom
Copy link
Member Author

emiliom commented Feb 25, 2023

oceanhackweek/jupyter-image#65 led to an R image deployment error (see 2i2c-org/infrastructure#2252 (comment)), which I tried to addressed with oceanhackweek/jupyter-image#66. But it looks like that PR led to a new, different R image deployment error. Sigh. That did it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ohw23es-intercoonecta Feb - Mar 2023 event in Spanish
Projects
None yet
Development

No branches or pull requests

2 participants