-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile required Python and R packages not already in the images #4
Comments
@abkfenris for the R image, do the R packages have to be conda packages? The conda lock file suggests that's the case, but the exchanges in oceanhackweek/jupyter-image#49 suggest otherwise. |
They don't have to be. For direct CRAN installs they can go into the Dockerfile: https://github.com/oceanhackweek/jupyter-image/blob/082c6937faaddf66b07311a96ebb1ed1670cff24/r/Dockerfile#L78-L93 The problem with that method is that errors are silently ignored during the build so Ben was playing with setting up a more generalized install script that could catch errors and fail appropriately. |
Ah, I wasn't aware of that mechanism. Thanks. We'll watch out for silent errors. |
Just for reference: I'm compiling the additional packages in Intercoonecta/tutoriales#1. But that's all in Spanish, plus I'll handle all the image updates. |
@abkfenris For CRAN and github R package additions, the statements in the Dockerfile include the following arguments, with the values being the same (
One of the packages I'm adding is from github, and the tutorial presenter is the developer. He asked me to include its dependencies. Should I set |
Dependencies should either be added manually via conda-forge or in the Dockerfile, so it takes a little work to figure out everything to add. R is bad about respecting dependencies that are already installed and then gets angry that there are multiple sources of dependencies. Ben was working on a script to try to play nicer (and fail appropriately), but I'm not sure what happened to it. |
I had a bad (I don't know what having a bad bunch is, unless I was referring to a bunch of packages 🙄) |
For reference, at least for the R package on github that I'm handling, the dependencies are listed in the |
I've created two image updates: Python (PR oceanhackweek/jupyter-image#64) and R (PR oceanhackweek/jupyter-image#65). |
oceanhackweek/jupyter-image#65 led to an R image deployment error (see 2i2c-org/infrastructure#2252 (comment)), which I |
I'll start communicating with the OHWes team to identify required packages.
In the meantime, for reference and as a guide, here are the issues @abkfenris created for OHW22 for this task:
The text was updated successfully, but these errors were encountered: