Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

다운로드 시 gif 광고 제외 #84

Open
occidere opened this issue Nov 11, 2018 · 2 comments
Open

다운로드 시 gif 광고 제외 #84

occidere opened this issue Nov 11, 2018 · 2 comments
Assignees
@occidere
Labels
bug enhancement

Comments

@occidere
Copy link
Owner

다운로드 시 gif 광고 제외

image
@occidere occidere self-assigned this Nov 11, 2018
@occidere
Copy link
Owner Author

접근방안

  1. 만화 파싱 대상 div 를 더 세분화 하여, 광고 영역은 건너뛰고 파싱
  2. 아예 gif 거르기
    • 만화가 gif 로 올라왔으면 대참사
    • 거르는 확장자를 하드코딩이 아닌, DB나 github 에 저장하고 읽어서 처리하게 하면 그나마 변경이 쉬움

@occidere
Copy link
Owner Author

hotfix/ignoreAds

occidere added a commit that referenced this issue Nov 18, 2018
@occidere
ver 0.5.3.0 업데이트
f9030d7 
Close #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occidere occidere

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@occidere