From bfdbf4d677a5eb9b15a449f8656c1f45ac5d125f Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:32:13 +0800 Subject: [PATCH 01/11] Fix typo folding/src/lib.rs --- folding/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folding/src/lib.rs b/folding/src/lib.rs index 1cd94a940e..8e34be8aae 100644 --- a/folding/src/lib.rs +++ b/folding/src/lib.rs @@ -218,7 +218,7 @@ impl<'a, CF: FoldingConfig> FoldingScheme<'a, CF> { let error_evals = error.map(|e| Evaluations::from_vec_and_domain(e, self.domain)); // Committing to the cross terms - // Default blinder for commiting to the cross terms + // Default blinder for committing to the cross terms let blinders = PolyComm::new(vec![ScalarField::::one()]); let error_commitments = error_evals .iter() From 1c36d8dd72da611394739c8249b4f0afc956dc00 Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:32:20 +0800 Subject: [PATCH 02/11] Fix typo folding/tests/test_folding_with_quadriticization.rs --- folding/tests/test_folding_with_quadriticization.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folding/tests/test_folding_with_quadriticization.rs b/folding/tests/test_folding_with_quadriticization.rs index 2d23f76510..12a4a43df1 100644 --- a/folding/tests/test_folding_with_quadriticization.rs +++ b/folding/tests/test_folding_with_quadriticization.rs @@ -181,7 +181,7 @@ impl FoldingEnv &[Fp] { From 2045a834aa3cc45d9b688b997b79a4667896919a Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:32:26 +0800 Subject: [PATCH 03/11] Fix typo folding/tests/test_quadraticization.rs --- folding/tests/test_quadraticization.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folding/tests/test_quadraticization.rs b/folding/tests/test_quadraticization.rs index 84f0df360e..b0a9cfea20 100644 --- a/folding/tests/test_quadraticization.rs +++ b/folding/tests/test_quadraticization.rs @@ -1,4 +1,4 @@ -//! quadraticization test, check that diferent cases result in the expected number of columns +//! quadraticization test, check that different cases result in the expected number of columns //! being added use ark_poly::Radix2EvaluationDomain; use folding::{ From c19692b27925890b04cbe9b06e888d42e01a690d Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:32:32 +0800 Subject: [PATCH 04/11] Fix typo ivc/tests/simple.rs --- ivc/tests/simple.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ivc/tests/simple.rs b/ivc/tests/simple.rs index c651e33652..47d4b63bc7 100644 --- a/ivc/tests/simple.rs +++ b/ivc/tests/simple.rs @@ -271,7 +271,7 @@ pub fn heavy_test_simple_add() { .map(|x| FoldingCompatibleExpr::from(x.clone())) .collect(); - // IVC column expression should be shifted to the right to accomodate + // IVC column expression should be shifted to the right to accommodate // app witness. let ivc_mapper = &(|Variable { col, row }| { let rel_offset: usize = AdditionColumn::COUNT; From 43e2d5c270a6c12fb084cf6def8277dac9545fd6 Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:32:38 +0800 Subject: [PATCH 05/11] Fix typo kimchi/src/snarky/constraint_system.rs --- kimchi/src/snarky/constraint_system.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kimchi/src/snarky/constraint_system.rs b/kimchi/src/snarky/constraint_system.rs index ed53a40e32..68cb88e732 100644 --- a/kimchi/src/snarky/constraint_system.rs +++ b/kimchi/src/snarky/constraint_system.rs @@ -625,7 +625,7 @@ impl SnarkyConstraintSystem { let public_input_size = self.public_input_size.unwrap(); let pub_selectors: Vec<_> = vec![ Field::one(), - // TODO: unecessary + // TODO: unnecessary Field::zero(), Field::zero(), Field::zero(), From b83df5795aaa12db56fe7697753833509df31927 Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:32:49 +0800 Subject: [PATCH 06/11] Fix typo kimchi/src/snarky/errors.rs --- kimchi/src/snarky/errors.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kimchi/src/snarky/errors.rs b/kimchi/src/snarky/errors.rs index c267bf5126..34ce17ff5a 100644 --- a/kimchi/src/snarky/errors.rs +++ b/kimchi/src/snarky/errors.rs @@ -12,7 +12,7 @@ pub type SnarkyRuntimeResult = std::result::Result pub type SnarkyCompileResult = std::result::Result; #[derive(Debug, Error)] -#[error("an error ocurred in snarky")] +#[error("an error occurred in snarky")] pub struct RealSnarkyError { /// The actual error. pub source: SnarkyError, From 528c67fd69a63aa79c8ee1d50aaeb76339d3151a Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:32:56 +0800 Subject: [PATCH 07/11] Fix typo msm/src/fec/interpreter.rs --- msm/src/fec/interpreter.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msm/src/fec/interpreter.rs b/msm/src/fec/interpreter.rs index ce3f78b39c..7bc16698a1 100644 --- a/msm/src/fec/interpreter.rs +++ b/msm/src/fec/interpreter.rs @@ -289,7 +289,7 @@ pub fn constrain_ec_addition< .enumerate() { if i % 6 == 5 { - // This should be a diferent range check depending on which big-limb we're processing? + // This should be a different range check depending on which big-limb we're processing? // So instead of one type of lookup we will have 5 different ones? env.lookup(LookupTable::RangeCheck9Abs, vec![x.clone()]); } else { From a051ac05a7b9a164d7c8b3a2cf32f42f7d76de7f Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:33:05 +0800 Subject: [PATCH 08/11] Fix typo msm/src/logup.rs --- msm/src/logup.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msm/src/logup.rs b/msm/src/logup.rs index 19ba65a191..f38c2ff171 100644 --- a/msm/src/logup.rs +++ b/msm/src/logup.rs @@ -553,7 +553,7 @@ pub mod prover { /// Create an environment for the prover to create a proof for the Logup protocol. /// The protocol does suppose that the individual lookup terms are /// committed as part of the columns. - /// Therefore, the protocol only focus on commiting to the "grand + /// Therefore, the protocol only focus on committing to the "grand /// product sum" and the "row-accumulated" values. pub fn create< OpeningProof: OpenProof, From 0310914f26b1ff5cc235ee3e1b0d6562e64b5190 Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:33:14 +0800 Subject: [PATCH 09/11] Fix typo msm/src/test/test_circuit/interpreter.rs --- msm/src/test/test_circuit/interpreter.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/msm/src/test/test_circuit/interpreter.rs b/msm/src/test/test_circuit/interpreter.rs index afb72942fd..7331a19ff5 100644 --- a/msm/src/test/test_circuit/interpreter.rs +++ b/msm/src/test/test_circuit/interpreter.rs @@ -162,7 +162,7 @@ pub fn constrain_test_fixed_sel_degree_7_with_constants< env: &mut Env, ) { let a0 = Env::read_column(env, TestColumn::A(0)); - let fourty_two = Env::constant(F::from(42u32)); + let forty_two = Env::constant(F::from(42u32)); let three = Env::constant(F::from(3u32)); let b0 = Env::read_column(env, TestColumn::B(0)); let fixed_e = Env::read_column(env, TestColumn::FixedSel1); @@ -170,7 +170,7 @@ pub fn constrain_test_fixed_sel_degree_7_with_constants< let a0_4 = a0_2.clone() * a0_2.clone(); let a0_6 = a0_4.clone() * a0_2.clone(); let a0_7 = a0_6.clone() * a0.clone(); - let equation = three * a0_7.clone() + fourty_two * b0.clone() - fixed_e; + let equation = three * a0_7.clone() + forty_two * b0.clone() - fixed_e; env.assert_zero(equation.clone()); } From bbf9fec1d6602773ae44e5b2bccc583083ea2699 Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:33:29 +0800 Subject: [PATCH 10/11] Fix typo poly-commitment/src/ipa.rs --- poly-commitment/src/ipa.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/poly-commitment/src/ipa.rs b/poly-commitment/src/ipa.rs index 17c561bb3d..47dd316e5b 100644 --- a/poly-commitment/src/ipa.rs +++ b/poly-commitment/src/ipa.rs @@ -410,7 +410,7 @@ where let coeffs: Vec<_> = plnm.iter().map(|c| c.into_bigint()).collect(); - // chunk while commiting + // chunk while committing let mut chunks = vec![]; if is_zero { chunks.push(G::zero()); From d7cb8ffe6634d7ef5c0a8c16791df1db0a9f6edc Mon Sep 17 00:00:00 2001 From: calciumbe <192480234+calciumbe@users.noreply.github.com> Date: Sat, 4 Jan 2025 16:33:42 +0800 Subject: [PATCH 11/11] Fix typo poly-commitment/src/utils.rs --- poly-commitment/src/utils.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/poly-commitment/src/utils.rs b/poly-commitment/src/utils.rs index fc43883aff..f91ff421d6 100644 --- a/poly-commitment/src/utils.rs +++ b/poly-commitment/src/utils.rs @@ -63,7 +63,7 @@ impl<'a, F: Field> ScaledChunkedPolynomial { /// Combine the polynomials using a scalar (`polyscale`), creating a single /// unified polynomial to open. This function also accepts polynomials in -/// evaluations form. In this case it applies an IFFT, and, if necessarry, +/// evaluations form. In this case it applies an IFFT, and, if necessary, /// applies chunking to it (ie. split it in multiple polynomials of /// degree less than the SRS size). ///