Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The egs++ angular spread source has unintuitive input #1214

Open
rtownson opened this issue Nov 3, 2024 · 1 comment
Open

The egs++ angular spread source has unintuitive input #1214

rtownson opened this issue Nov 3, 2024 · 1 comment

Comments

@rtownson
Copy link
Collaborator

rtownson commented Nov 3, 2024

To define the Gaussian by FWHM, it takes a negative sigma input. We might as well just add a fwhm input to make this more user friendly.

@ftessier
Copy link
Member

ftessier commented Nov 3, 2024

Yes, I fully agree! Eventually, we ought to get rid of all cases where negative numbers are used as flags (yes, this includes negative energies for new histories in phase space files). But let's add fwhm right away! Now we do have to guard against negative "sigmas" anyways, so we might add a fatal error message that includes a note about this change of behaviour!

@ftessier ftessier added this to the Release 2025 milestone Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants