Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] e.stopImmediatePropagatio() really need? #55

Closed
vlukyanoff opened this issue Sep 15, 2017 · 5 comments
Closed

[Question] e.stopImmediatePropagatio() really need? #55

vlukyanoff opened this issue Sep 15, 2017 · 5 comments

Comments

@vlukyanoff
Copy link

Hi, @noeldelgado!

I can't use mouseDown event on block with gemini scrollbar because gemini call e.stopImmediatePropagation() in _startDrag function.
I know, stop propagation isn't best practice, because it changes standart behavios of the browser.
Maybe, is there way to avoid stop propogation in this case?

e.stopImmediatePropagation();

@vlukyanoff vlukyanoff changed the title [QUESTION] e.stopImmediatePropagatio() really need? [Question] e.stopImmediatePropagatio() really need? Sep 15, 2017
@noeldelgado
Copy link
Owner

Hi @vlukyanoff, did #56 fix the issue? (v1.5.3)

@vlukyanoff
Copy link
Author

Hi @noeldelgado! Yes, it fixed the issue. Thank you!

@vlukyanoff
Copy link
Author

@noeldelgado, could you update dependency in https://github.com/noeldelgado/react-gemini-scrollbar please?

@Guria
Copy link

Guria commented Oct 19, 2017

I would be great if gemini-scrollbar were peerDependency of react-gemini-scrollbar to avoid such update needs.

@noeldelgado
Copy link
Owner

@vlukyanoff done, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants