-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarification on when/how to use util.aborted
#55340
Comments
aduh95
pushed a commit
that referenced
this issue
Dec 18, 2024
PR-URL: #55780 Fixes: #55340 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
aduh95
pushed a commit
that referenced
this issue
Dec 18, 2024
PR-URL: #55780 Fixes: #55340 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
ruyadorno
pushed a commit
that referenced
this issue
Dec 20, 2024
PR-URL: #55780 Fixes: #55340 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
ruyadorno
pushed a commit
that referenced
this issue
Dec 21, 2024
PR-URL: #55780 Fixes: #55340 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
ruyadorno
pushed a commit
that referenced
this issue
Jan 5, 2025
PR-URL: #55780 Fixes: #55340 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jason Zhang <[email protected]> Reviewed-By: Minwoo Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected URL(s)
https://nodejs.org/api/util.html#utilabortedsignal-resource
Description of the problem
The docs aren't entirely clear on the purpose of the second
optionalargument (resource
), how it's supposed to be used, or when it's useful. One of the primary use cases for this util function seems to be aborting a promise that doesn't support abort natively, but I'm not sure what I should pass as the resource?Am I thinking about this use case correctly, or is not passing resource somehow creating a memory leak / preventing things from being cleaned up properly?
EDIT: It seems I misunderstood the second argument being optional, it appears required, but questions still remain how it's supposed to be used for the example above.
The text was updated successfully, but these errors were encountered: