From 9efb0e8140a2f4e59753d70cd4c8780f7175b8d8 Mon Sep 17 00:00:00 2001
From: ItamarGoldman <51112651+ItamarGoldman@users.noreply.github.com>
Date: Thu, 21 Dec 2023 09:40:38 +0200
Subject: [PATCH] Make figures loaded from experiment db viewable in notebook
 (#1321)

### Summary

Make figures loaded from experiment db viewable in jupyter notebook as
suggested in #436 .
### Details and comments

Some details that should be in this section include:

- Why this change was necessary
  To  make it more comfortable to use figures in jupyter notebook.
- What do users and developers need to know about this change
To display figures of experiment data that were loaded from experiment
db don't need to convert to SVG.

---------

Co-authored-by: Will Shanks <wshaos@posteo.net>
---
 docs/howtos/cloud_service.rst                              | 6 ++----
 qiskit_experiments/framework/experiment_data.py            | 3 ++-
 releasenotes/notes/figure_return_SVG-4ad72fc8a3bee3cb.yaml | 4 ++++
 3 files changed, 8 insertions(+), 5 deletions(-)
 create mode 100644 releasenotes/notes/figure_return_SVG-4ad72fc8a3bee3cb.yaml

diff --git a/docs/howtos/cloud_service.rst b/docs/howtos/cloud_service.rst
index a244232ca7..11bce3f7f8 100644
--- a/docs/howtos/cloud_service.rst
+++ b/docs/howtos/cloud_service.rst
@@ -59,13 +59,11 @@ experiment <https://quantum.ibm.com/experiments/9640736e-d797-4321-b063-d503f8e9
     service = ExperimentData.get_service_from_backend(backend)
     load_expdata = ExperimentData.load("9640736e-d797-4321-b063-d503f8e98571", service)
 
-To display the figure, which is serialized into a string, we need the
-``SVG`` library:
+Now we can display the figure from the loaded experiment data:
 
 .. jupyter-input::
 
-    from IPython.display import SVG
-    SVG(load_expdata.figure(0).figure)
+    load_expdata.figure(0)
 
 .. image:: ./experiment_cloud_service/t1_loaded.png
 
diff --git a/qiskit_experiments/framework/experiment_data.py b/qiskit_experiments/framework/experiment_data.py
index c42f610ad4..9fea0818cd 100644
--- a/qiskit_experiments/framework/experiment_data.py
+++ b/qiskit_experiments/framework/experiment_data.py
@@ -67,6 +67,7 @@
     ExperimentDataSaveFailed,
 )
 
+
 if TYPE_CHECKING:
     # There is a cyclical dependency here, but the name needs to exist for
     # Sphinx on Python 3.9+ to link type hints correctly.  The gating on
@@ -192,7 +193,7 @@ def _repr_svg_(self):
         if isinstance(self.figure, str):
             return self.figure
         if isinstance(self.figure, bytes):
-            return str(self.figure)
+            return self.figure.decode("utf-8")
         return None
 
 
diff --git a/releasenotes/notes/figure_return_SVG-4ad72fc8a3bee3cb.yaml b/releasenotes/notes/figure_return_SVG-4ad72fc8a3bee3cb.yaml
new file mode 100644
index 0000000000..bd1bf8104f
--- /dev/null
+++ b/releasenotes/notes/figure_return_SVG-4ad72fc8a3bee3cb.yaml
@@ -0,0 +1,4 @@
+---
+fixes:
+  - |
+    Figures loaded from the experiment service are now rendered correctly in Jupyter Notebook.