From 1bebee1d80ae2538b0dd16727c0bc05c897e1e8d Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Mon, 23 Sep 2024 14:04:53 +0200 Subject: [PATCH 1/2] MNT: Apply repo-review rule PP002 PP002: Has a proper build-system table Must have `build-system.requires` and `build-system.backend`. Both should be present in all modern packages. --- pyproject.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/pyproject.toml b/pyproject.toml index 94d61f289e..db63ddd60f 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,5 +1,6 @@ [build-system] requires = ["setuptools >= 30.3.0", "wheel"] +build-backend = "setuptools.build_meta" [tool.black] skip-string-normalization = true From e4c8f87392169fb6d1919b2f60cc6416dc3a8981 Mon Sep 17 00:00:00 2001 From: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com> Date: Mon, 23 Sep 2024 13:53:55 +0200 Subject: [PATCH 2/2] MNT: Apply repo-review rule PP003 PP003: Does not list wheel as a build-dep Do not include `"wheel"` in your `build-system.requires`, setuptools does this via PEP 517 already. Setuptools will also only require this for actual wheel builds, and might have version limits. --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index db63ddd60f..06f4d798c7 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,5 +1,5 @@ [build-system] -requires = ["setuptools >= 30.3.0", "wheel"] +requires = ["setuptools >= 30.3.0"] build-backend = "setuptools.build_meta" [tool.black]