Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browsing duplicates facets #166

Open
ACharbonneau opened this issue Mar 8, 2021 · 5 comments
Open

Browsing duplicates facets #166

ACharbonneau opened this issue Mar 8, 2021 · 5 comments

Comments

@ACharbonneau
Copy link
Contributor

I started looking at 'browse by anatomy', specifically at 'characterized files':

image

From there, I chose "Explore" which takes me to a files browser, where it adds "Anatomy" as a facet, but there is already an "Anatomy" facet on file pages, so now I have two:

image

@karlcz
Copy link
Contributor

karlcz commented Mar 15, 2021

This is an interesting UX quirk. @jrchudy can you help investigate this? Here are steps I used to reproduce:

  1. Go to the navbar Browse All Data -> Vocabulary -> Anatomy recordset
  2. View the record page for an anatomy term (such as pancreas or breast)
  3. Scroll down to the Characterized Files related entity section
  4. Use the Explore button for those related entities
    You'll see an open facet near the top of the list for "Anatomy" which is the one I've configured in visible columns. You'll also see an extra one at the bottom with your chosen anatomy term for this Explore step.
    I think the relationship being found is the file_anatomy association table, which is also what I use in the facet definition. However, I think the facet may be using the anatomy id key while the Explore function is using the RID key... is there a way to get the explore function to use id instead?

@jrchudy
Copy link
Contributor

jrchudy commented Mar 17, 2021

I think the facet may be using the anatomy id key while the Explore function is using the RID key.

I asked about this in the stand up meeting today and this seems to be the case. I will investigate further tomorrow, but I imagine this is the case. To prevent this with the current behavior of the annotation and chaise, the RID would have to be configured for the facet model definition.

@karlcz
Copy link
Contributor

karlcz commented Sep 13, 2021

I think this is no longer an issue with the recent release where we use nid keys for facets and these are also the "shortest key" chosen by Chaise. @jrchudy can you confirm?

@jrchudy
Copy link
Contributor

jrchudy commented Sep 29, 2021

I can still reproduce this issue starting from this anatomy page and clicking "Explore" for the Biosample data. I then see 2 Anatomy facets (and Anatomy (slim).

@karlcz
Copy link
Contributor

karlcz commented Dec 7, 2021

The reproduced problem, described by @jrchudy above is a different issue. As far as I can tell, we no longer have the problem of facets with different entity keys appearing as duplicates.

The search facet and the related entity section from the vocab are not actually using the same path, so it is not so much a duplicated facet as two different relationships being given the same display name. This will need more case-by-case consideration to decide how to resolve them.

Possible approaches:

  • Set distinct display names for the reversed related entity paths.
  • Change the related entities to use the same path as the facet. In certain cases, this might produce identical results, but in other cases it means the UI would show what is linked via search, not just what is linked directly via a certain C2M2 association table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants