Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for a custom storage provider #6

Open
shkvoretz opened this issue Apr 24, 2020 · 15 comments
Open

Support for a custom storage provider #6

shkvoretz opened this issue Apr 24, 2020 · 15 comments
Labels
enhancement New feature or request PR is welcome

Comments

@shkvoretz
Copy link

This module supported a custom storage provider when it was part of Akita. Now, it appears only to support localStorage. Limitations of localStorage are well known and it would be nice if the old functionality was brought back so that the state could be saved to things like IndexedDB or similar. This is specially vital for things like hybrid apps where webview storage may be purged by the OS and the only way to ensure persistence of the data is to save it to SQLite or similar. Support for a custom storage provider or at least IndexedDB would be nice. Thanks

@NetanelBasal
Copy link
Member

Do you maybe want to create a PR?

@shkvoretz
Copy link
Author

Do you maybe want to create a PR?

yip, will do.

@NetanelBasal NetanelBasal added enhancement New feature or request PR is welcome labels Apr 29, 2020
@Destreyf
Copy link

I wanted to add my 2 cents here, I'm looking at using this library for a complex project that's coming up, it looks like a great fit but I want up add another layer to the storage system, it would be nice if there was an adapter like system that could be plugged either at a module config level or perhaps at the time that you attach the form manager to the form group.

Essentially my is use case is to create a real time editor with collaborative functionality, having an adapter that could broadcast that changes would be helpful, I haven't tried to POC this yet but I believe it would work for my use case.

I could always write my own code to handle it directly with the form groups, but I believe with a little work it could be flexible enough to handle it.

@Destreyf
Copy link

Oops, forgot to clarify, I would be using an websocket to store drafts and state, so I would intend to leverage this as a network back end essentially. Backed by redis for the session.

@NetanelBasal
Copy link
Member

@Destreyf, you're welcome to submit a PR.

@Destreyf
Copy link

@NetanelBasal I'll be looking into this more next week, I just happened to stumble onto your library from the akita blog post.

@stefanoww
Copy link

@NetanelBasal I might take this one.

@NetanelBasal
Copy link
Member

Ok

@TakeshiDaveau
Copy link

Hi,

Is there any update for this ?

Thx in advance

@va-stefanek
Copy link

@NetanelBasal I am thinking whether you sees an option to put that functionality into some package or something, because there is similar request in another lib - ngneat/cashew#21

@NetanelBasal
Copy link
Member

If I would create a package, would you do it, and use it in both libraries?

@va-stefanek
Copy link

Yea I am eager to help, very similar functionality is in the https://github.com/ngneat/reactive-forms. I might even help with the lib if you would like to.

@NetanelBasal
Copy link
Member

@va-stefanek
Copy link

Thanks @NetanelBasal I will start this weekend.

@va-stefanek
Copy link

@NetanelBasal I need your help with releasing it to the npm, am I allowed to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR is welcome
Projects
None yet
Development

No branches or pull requests

6 participants