Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query_reviewer 0.2.1 causes wrong number of arguments error in Rails 3.0 #33

Open
jshraibman-mdsol opened this issue Sep 16, 2013 · 3 comments
Open

query_reviewer 0.2.1 causes wrong number of arguments error in Rails 3.0 #33

jshraibman-mdsol opened this issue Sep 16, 2013 · 3 comments

Comments

@jshraibman-mdsol
Copy link

screen shot 2013-09-16 at 4 45 20 pm
@nesquena
Copy link
Owner

Damn yeah updated query_reviewer to support 3.2 and 4 and probably broke 3. If anyone has the time to patch it to support both, I'll be more than happy to pull it in. You can also lock to older version for now.

@jshraibman-mdsol
Copy link
Author

Do you know if 3.1 also needs the old method signature?

@nesquena
Copy link
Owner

My understanding is the signature changed in 3.2.

nesquena added a commit that referenced this issue Sep 16, 2013
@nesquena
Merge pull request #34 from jshraibman-mdsol/master
ed57e12 
Attempt to fix issue #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nesquena @jshraibman-mdsol