Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong arguments in the mast3r_sfm branch #99

Open
LaFeuilleMorte opened this issue Dec 19, 2024 · 2 comments
Open

Wrong arguments in the mast3r_sfm branch #99

LaFeuilleMorte opened this issue Dec 19, 2024 · 2 comments

Comments

@LaFeuilleMorte
Copy link

Hi, I've found a bug in the mast3r_sfm branch.
image

The function signature was:
image

So the pixel_tol will be passed to subsample instead of pixel_tol

@DabblerGISer
Copy link

It raised 'Error float division by zero' when I tried to run the code. And than I edited it as:
im_images_chunk = get_im_matches(pred1, pred2, pairs_chunk, image_to_colmap,
im_keypoints, conf_thr, subsample=8, pixel_tol=0)
im_matches.update(im_images_chunk.items())
don't know if it is correct

@DabblerGISer
Copy link

2024-12-31 11-01-11 的屏幕截图
I guess it works

yocabon added a commit that referenced this issue Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants