Incorrect minimum value comparison logic in Jakarta/Javax ValidationConstraintGenerator

[Seol-JY]

Describe the bug

In JakartaValidationConstraintGenerator class (line 365), there appears to be a meaningless self-comparison operation:

negativeMin = negativeMin.min(negativeMin);

It appears this was intended to be:

negativeMin = negativeMin.min(decimalMin);

For what seems to be a mistake, I tried to verify with the following test case:

public static class A {
    public A() {}

    public A(BigDecimal value) {
        this.value = value;
    }

    @NotNull
    @Max(-49)
    @Min(-100)
    @DecimalMin("-49.9")
    private BigDecimal value;

    public BigDecimal getValue() {
        return value;
    }

    public void setValue(BigDecimal value) {
        this.value = value;
    }
}

Expected the final negativeMin to be -100 which should cause validation errors, but the code runs without exceptions.

Your environment

• version of Fixture Monkey: 1.1.5
• version of Java: 17

The code contains a self-comparison operation in its minimum value calculation, yet the validation process operates as expected in test cases.

I would like to understand:
Whether this code represents an actual issue
If it is an issue, why the test case still functions correctly

[seongahjo]

@Seol-JY
Hi!

Thank you for reporting an issue.

Whether this code represents an actual issue If it is an issue, why the test case still functions correctly

That's because Fixture Monkey has two logical flows to satisfy the validation. link

Although the first flow (JakartaValidationConstraintGenerator) made a mistake, the second flow takes care of the problem.

It seems you are interested in contributing, could you do a PR for this issue?

Thank you.