Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest svelte versions #897

Open
jangxyz opened this issue Nov 4, 2024 · 0 comments
Open

Support latest svelte versions #897

jangxyz opened this issue Nov 4, 2024 · 0 comments
Assignees
Labels
🔖4.x v4.x~ related issue 📦Svelte @egjs/svelte-flicking related issue

Comments

@jangxyz
Copy link
Contributor

jangxyz commented Nov 4, 2024

Description

Svelte 5 is out, but I noticed it's been a while since the @egjs/svelte-flicking package kept on support. It's latest compatible svelte version in package.json is "^3.39.0", which is quite old if you consider svelte 4 was released on June, 2023.

It currently shows the following error:

Error
error during build:
[vite-plugin-svelte] [plugin vite-plugin-svelte] node_modules/@egjs/svelte-flicking/lib/flicking.svelte (6:24): node_modules/@egjs/svelte-flicking/lib/flicking.svelte:6:24 `p` has already been declared
file: /home/qo5ip4we0aj4vrkeetv8swp3pbyxe1-fmt4/node_modules/@egjs/svelte-flicking/lib/flicking.svelte:6:24

 4 |          t[p] = s[p];
 5 |      if (s != null && typeof Object.getOwnPropertySymbols === "function")
 6 |          for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) {
                               ^
 7 |              if (e.indexOf(p[i]) < 0 && Object.prototype.propertyIsEnumerable.call(s, p[i]))
 8 |                  t[p[i]] = s[p[i]];

The error itself seems simple -- svelte compiler catching duplicate p variable declarations. I have not looked into it any deeper.

To be clear, it was already not working even before svelte 5 was out. The typical "install and import" scenario didn't work, and I had to "copy all the source code into a separate directory", and use the code as it was my own source code. That did work.

Steps to check or reproduce

Here's a link to sveltelab with the basic code, from the Quick Start docs: https://www.sveltelab.dev/npxbmf2i342958j

@malangfox malangfox self-assigned this Nov 11, 2024
@malangfox malangfox added 🔖4.x v4.x~ related issue 📦Svelte @egjs/svelte-flicking related issue labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔖4.x v4.x~ related issue 📦Svelte @egjs/svelte-flicking related issue
Projects
None yet
Development

No branches or pull requests

2 participants