ConnectTimeout does not cancel upgrade of TcpConnection to SslConnection

[joao-genebra]

When opening a connection, after the connection has been created and before it is upgraded to ssl here, if some kind of hiccup occurs in our network, the timeout value set in ConnectTimeout of NatsOpts is not stopping the connection upgrade, which is causing the call to ConnectAsync to stay blocked.

We know that the connection has already been opened because we can find this log.

[mtmk]

I'm guessing the call to AuthenticateAsClientAsync is blocking. I wonder if passing CancellationToken with timeout would help.

https://github.com/nats-io/nats.net.v2/blob/f326e746f570bd45ac3641cd970c7e2539e51b8b/src/NATS.Client.Core/Internal/SslStreamConnection.cs#L88

[mtmk]

@joao-genebra which version of the client are you using btw. We have some big changes in 2.1.0-preview.1

[joao-genebra]

The NATS client version we are using is 2.0.1. We would rather not use a preview version and prefer to wait for a stable version.

Also, the behavior seems to be flaky and is only happening in production, so we are not able to replicate it locally.

Regarding your suggestion of passing a CancellationToken, it would be better if we were able to pass it directly to ConnectAsync.

Here are the logs showing what I had described earlier:

[mtmk]

Thanks for the report @joao-genebra. it looks like a bug.

Opened an issue for this #337 please follow up there.

[mtmk]

@joao-genebra sorry the fix delayed a little because of an unrelated issue. fix to this issue is in 2.1.0-preview.4. it'd be great if you have the opportunity to test it. Thank you!