Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install deep peer dependencies #251

Open
mayorovp opened this issue Sep 23, 2024 · 6 comments
Open

Cannot install deep peer dependencies #251

mayorovp opened this issue Sep 23, 2024 · 6 comments

Comments

@mayorovp
Copy link

MCVE:

npm init
npx install-peerdeps @typespec/html-program-viewer

Expected result

@types/react package is installed

Actual result

Only @typespec/html-program-viewer and @typespec/compiler are installed

@ljharb
Copy link
Collaborator

ljharb commented Sep 23, 2024

why would you expect @types/react to be installed? https://unpkg.com/browse/@typespec/[email protected]/package.json lists @typespec/compiler as the only peer dep.

@mayorovp
Copy link
Author

mayorovp commented Sep 23, 2024 via email

@mayorovp
Copy link
Author

mayorovp commented Sep 23, 2024 via email

@ljharb
Copy link
Collaborator

ljharb commented Sep 23, 2024

Then that's probably yarn being broken, as it often is. If you're using PnP, try disabling that.

@mayorovp
Copy link
Author

mayorovp commented Sep 24, 2024 via email

@ljharb
Copy link
Collaborator

ljharb commented Sep 24, 2024

DT packages should only be dev deps ever, and this tool isn’t intended to install transitive peer deps afaik. It’s each package’s responsibility to explicitly list all the peer deps its dependencies, and not let them be implicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants