Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-environmental physics for positional audio? (Doppler, phase) #5934

Closed
will-ca opened this issue Oct 18, 2022 · 3 comments
Closed

Use non-environmental physics for positional audio? (Doppler, phase) #5934

will-ca opened this issue Oct 18, 2022 · 3 comments
Labels
client feature-request This issue or PR deals with a new feature positional audio

Comments

@will-ca
Copy link

will-ca commented Oct 18, 2022

Context

No response

Description

Note: #3234 seems to primarily be about using game map data to simulate evironmental effects like occlusion, attenuation, and reverb, requiring deeper app integration. This is specifically about effects that do not require any more information than should already be available, so I'm opening a new issue.

Phase shift is very important for audio localization, as differences in volume aren't always that great, especially for far-away sources:

https://en.wikipedia.org/wiki/Sound_localization

However, web search shows that this has apparently never been discussed in connection with Mumble.

https://www.google.com/search?hl=en&q=%22mumble%22%20voip%20%22phase%22

On a technical basis, this should be pretty straightforward. Find the difference in distance between the two ears, divide by the speed of sound, and delay one channel by that much.

EDIT: Already implemented in #5094.

Doppler is less universally important, but could be cool in certain settings.

If it can be broken into chunks, it can be as simple as speeding up or slowing down playback. If not, I suppose it can probably be resampled continuously.


Phase shift only requires positioning/orientation, which are presumably already required anyway.

Doppler requires speed, which can be computed from position changes.

Both doppler and phase shift would organically emerge from simulating speed of sound per ear.

Mumble component

Client

OS-specific?

No

Additional information

See also: #1933

@will-ca will-ca added feature-request This issue or PR deals with a new feature triage This issue is waiting to be triaged by one of the project members labels Oct 18, 2022
@Krzmbrzl
Copy link
Member

Find the difference in distance between the two ears, divide by the speed of sound, and delay one channel by that much.

That's already implemented via #5094 (if I understood you correctly)

@Krzmbrzl Krzmbrzl added client positional audio and removed triage This issue is waiting to be triaged by one of the project members labels Oct 18, 2022
@will-ca
Copy link
Author

will-ca commented Oct 18, 2022

That's already implemented via #5094 (if I understood you correctly)

I suppose it is. I did not find it as it used different terminology, but that is the same phenomenon.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Oct 3, 2024

This is now tracked as part of #6597

@Krzmbrzl Krzmbrzl closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature positional audio
Projects
None yet
Development

No branches or pull requests

2 participants