Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider use of static typing (mypy and comment-based annotations) #16

Open
mulkieran opened this issue Mar 14, 2016 · 5 comments
Open

Comments

@mulkieran
Copy link
Owner

No description provided.

@mulkieran
Copy link
Owner Author

It's still a bit hard to do. mypy doesn't seem to have a Fedora package, linting requires python3, probably, or to run in a python3 compatible mode, or something.

************* Module justbases._nats
src/justbases/_nats.py:19: [W0611(unused-import), ] Unused List imported from typing
src/justbases/_nats.py:20: [W0611(unused-import), ] Unused Tuple imported from typing

Pylint would consider these things unused, because in a Python2/Python3 compatible implementation they appear in the comments, not the source. Of course, warning is easy to disable.

@mulkieran
Copy link
Owner Author

Actually, mypy is being maintained for Fedora 24 and above. So, that's one obstacle removed.

@mulkieran
Copy link
Owner Author

Actually, until I can understand what it offers, it is not at all clear that it is useful. It should not be possible to claim that all my methods are int -> int when none of them are and not get an error. Funny.

@mulkieran
Copy link
Owner Author

Things are not as bad as all that. There is even a working PR: #23.

@mulkieran
Copy link
Owner Author

Working PR requires a rebase, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant