Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Separator] Support vertical orientation #1303

Closed
aarongarciah opened this issue Jan 8, 2025 · 1 comment · Fixed by #1304
Closed

[Separator] Support vertical orientation #1303

aarongarciah opened this issue Jan 8, 2025 · 1 comment · Fixed by #1304
Assignees
Labels
component: separator This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@aarongarciah
Copy link
Member

Feature request

Summary

Support vertical orientation on the Separator component.

Examples in other libraries

Motivation

According to the WAI-ARIA spec, elements with role="separator" support aria-orientation="horizontal|vertical". Most libraries support vertical orientation so most users would expect to have a prop for it instead of adding aria-orientation="vertical" by themselves.

Alternatives

Don't provide a prop to change the orientation and just guide user on the docs to add the corresponding aria-orientation="vertical" attribute when in need of a vertical separator. This is already the case when users need to make a focusable/interactive separator, since they'd need to manage the aria-disabled, aria-valuemax, aria-valuemin, etc. attributes (see https://www.w3.org/TR/wai-aria-1.2/#separator), but interactive separators are way less common than static ones and could be considered an advanced use case.

@aarongarciah aarongarciah added component: separator This is the name of the generic UI component, not the React module! new feature New feature or request labels Jan 8, 2025
@mj12albert
Copy link
Member

It's needed for #661 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: separator This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants