Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release v2 page in the admin ui is very slow #2995

Open
jcristau opened this issue Oct 5, 2023 · 9 comments
Open

release v2 page in the admin ui is very slow #2995

jcristau opened this issue Oct 5, 2023 · 9 comments
Labels
admin admin app & api (aus4-admin.mozilla.org) frontend ui issues

Comments

@jcristau
Copy link
Contributor

jcristau commented Oct 5, 2023

Going to any release page in the admin ui, e.g. https://balrog.services.mozilla.com/releases/Firefox-mozilla-central-nightly-latest/v2, makes a request to https://aus4-admin.mozilla.org/api/v2/releases, which takes forever (about 30s for me). It seems wasteful to query the entire list of releases here...

I'm not sure whether this is entirely an UI problem or if it requires new API to fix.

@jcristau jcristau added the admin admin app & api (aus4-admin.mozilla.org) label Oct 5, 2023
@ademolaomosanya
Copy link

i would love to work on this issue kindly assign me

@jcristau
Copy link
Contributor Author

jcristau commented Oct 5, 2023

Relatedly, https://balrog.services.mozilla.com/releases/ also makes a request to the releases list, which makes more sense, but which I'm seeing time out after 1 minute, and return 502.

@gabrielBusta
Copy link
Member

I don't think this needs API changes. I should be possible to pass the release name to the endpoint I think? (it's displayed at the top of the page)

https://aus4-admin.mozilla.org/api/v2/releases/Firefox-mozilla-central-nightly-latest

@jcristau
Copy link
Contributor Author

jcristau commented Oct 5, 2023

The UI also does that request for the specific release's contents, but it gets some extra metadata from the "give me all releases" endpoint.

@gabrielBusta
Copy link
Member

gabrielBusta commented Oct 11, 2023

@ademolaomosanya are you applying for outreachy?

@gabrielBusta
Copy link
Member

We are letting applicants work on whatever issues are available, and not worry about being assigned to things (in part because there's more contributors than issues.) The experience is valuable to everyone (even if an applicant's pull-request is not the one that ends up merged.)

@gabrielBusta gabrielBusta added the frontend ui issues label Oct 11, 2023
@bhearsum
Copy link
Contributor

bhearsum commented Oct 12, 2023

Just for the record, I'm not sure this is a frontend issue, at least not exclusively. There may be cases where we can avoid hitting this endpoint altogether, but the root problem is that the /api/v2/release is incredibly slow.

@ademolaomosanya
Copy link

@ademolaomosanya are you applying for outreachy?

yes

@bhearsum
Copy link
Contributor

One factor here is that we're never started removing stale releases from the v2 table, like we do for v1. Doing that would go a long way to speeding this up.

One hitch here is that we'll want to make sure we remove any associated data from GCS as well (which is where the actual release blobs are stored for v2 releases). This is likely to involve some manual GCS endpoint manipulation, as the db.py classes will not remove any data from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin admin app & api (aus4-admin.mozilla.org) frontend ui issues
Projects
None yet
Development

No branches or pull requests

4 participants