-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Household option #93
Comments
Oh wow, this is great! I like that you already implemented a version of this for v1. Is there a way for me to check out your implementation and see the feature in action? Happy to move this discussion to another channel :)
Happy to have collaborators on this! From a pure feature perspective I'd imagine it like this:
Open questions would be
But this needs a thorough discussion and look at the feature. The UX is very important as well. I haven't thought this through at all yet, as it has just been living in my backlog until now. |
If you have a preffered other channel, let me know. Slack/Discord/Skype etc. are all fine by me. My fork should be public (https://github.com/matthijsthoolen/happy-plants), this feature is implemented in the custom/matthijs branch. Be aware that it is a PoC and for my own use, so it has some rough edges :) |
I've created a community on Spectrum: https://spectrum.chat/happyplants. If you join there, we can have private discussions ;) |
Hi Morkro!
The new v2 option is looking really great! Thanks for all the effort.
I would really love to be able to use the new design and the new features.
For v1 I have created some small additions for my own forked project, they were mostly designed to be only used by me because you were working on the v2 version already. So it was a good opportunity to get up and running with vue.js and the project.
One of the things I have added was an option to share your plants with others (with some small changes that they were not allowed to remove plants or tags). To 'connect' with the plants of another person I have added a unique code you have to enter to join their household.
But this is not something I want to implement in this version, mainly because it might not be that secure :)
I have a few ideas how this can be implemented:
Dont make the user the first collection (dont know what the correct naming is), but create a household instead (might be hard to make a migration for exiting data...). A user can than be connected to a household, an owner can be set which in turn can 'open' the household and accept or deny new members.
Keep the user as the main collection, and use the user document as a 'joinable entity'. This might work (I did it in my PoC), but it might be a bit of a hackish way).
Can you give your opinion about this feature? I can (help) implement this, but would like some advise :)
The text was updated successfully, but these errors were encountered: