Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of this repository #4

Open
prusnak opened this issue Dec 6, 2017 · 2 comments
Open

State of this repository #4

prusnak opened this issue Dec 6, 2017 · 2 comments

Comments

@prusnak
Copy link

prusnak commented Dec 6, 2017

What is the state of this repository?

The last commit seems two years old, but at the same time readme mentions RingCT.

Is this implementation compatible with the current Monero network?

Readme also mentions https://github.com/ShenNoether/RingCT-Python repository, but that is no longer existent. Can anyone point me to a new location?

// cc @fluffypony

@dEBRUYNE-1
Copy link

dEBRUYNE-1 commented Dec 14, 2017

Did you look at this repository?

https://github.com/monero-project/research-lab

I am not sure if that particular code is also there, but regardless, there's a lot of demo code in that repository.

P.S. I strongly encourage you to use our IRC channels as well (#monero-dev and #monero-research-lab in particular).

@luigi1111
Copy link

luigi1111 commented Dec 14, 2017

@prusnak There are a few things that won't match the live implementation, notably:

  1. ASNL has been replaced with Borromean (and sometime soon-ish that'll probably be replaced/used side-by-side with bulletproofs)
  2. MLSAGs in live are always 2 rows, rather than #inputs+1 rows, due to column linkability. This means there is one MLSAG per input and a new "pseudoOut" is introduced for txs with more than one input (see: https://github.com/monero-project/monero/blob/master/src/ringct/rctSigs.cpp#L670)
  3. There is a minor change to encrypt the mask and amount with the recipient's viewkey, rather than the destination pubkey.

The rest looks pretty close from a brief perusal, but of course this is not authoritative.

Edit: I'm talking about this file in particular: https://github.com/monero-project/mininero/blob/master/RingCT2.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants