Traktor Kontrol S3 mapping issue in v2.4.1 (PitchSlider = FALSE)

[zebebop]

Bug Description

Great! Thanks for testing! I guess this is because the tempo-sliders are mapped to work relative and not absolute - can be configured at the top of the mapping file btw.:

mixxx/res/controllers/Traktor-Kontrol-S3-hid-scripts.js

Lines 54 to 67 in d7a769b

	// The pitch slider can operate either in absolute or relative mode.
	// In absolute mode:
	// * Moving the pitch slider works like normal
	// * Mixxx will use soft-takeover
	// * Pressing shift will adjust musical pitch instead of rate
	// * Keylock toggles on with down-press.
	//
	// In relative mode:
	// * The slider always moves, unless it has hit the end of the range inside Mixxx
	// * No soft-takeover
	// * Hold shift to move the pitch slider without adjusting the rate
	// * Hold keylock and move the pitch slider to adjust musical pitch
	// * keylock will still toggle on, but on release, not press.
	TraktorS3.PitchSliderRelativeMode = true;

Hello, I just realized that this modification (the TRUE command must be set to FALSE) of the config file "Traktor-Kontrol-S3-hid-scripts.js" of the Native Instrument Traktor S3 controller has not been taken into account and integrated directly into the latest version v2.4.1 of Mixxx. Best regards.

Version

2.4.1

OS

Windows 10, Macos BigSur, Linux Mint 22

[ronso0]

So this report is just for saying thanks ? : )

[zebebop]

Funny :) No, it's so that the modification is made in the original script at installation, without having to make the modification manually afterwards... Otherwise, how many "beginner" users with a Traktor S3 will find themselves stuck without knowing what to do? For me it's good, I think of the others...

[ronso0]

Okay, thank you. I just didn't spot the issue in the block you quoted.

Indeed true for relative mode doesn't match the mapping description which says

There are two ways the rate sliders can be mapped: Absolute, and Relative. Absolute mode is the default. In this mode, the position of the pitch slider matches the on-screen pitch slider position.

Do you mind opening a PR with the fix?