Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake when calculating Rel statistics #1

Open
williamLyh opened this issue Jun 26, 2021 · 0 comments
Open

Mistake when calculating Rel statistics #1

williamLyh opened this issue Jun 26, 2021 · 0 comments

Comments

@williamLyh
Copy link

williamLyh commented Jun 26, 2021

Hi!
I believe there's a mistake in stats.py line 23.
The eid is the object_id, which could correspond to more than one object synset, but here the first synset will be overwritten by the second synset (or the last one if there are more than 2). This leads a decrease in information in the returned entities dictionary, which means when calculating the relation, only one of the synset is considered.
For example, when object_id=162759, the objects are ['position.n', 'ocean.n'], but entities['162759'] is only 'position.n'
I think this could be a mistake and you might want to handle this more carefully.

Best,
Yinhong Liu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant