Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vcpkg_build_make has empty logfile prefix with newer versions of CMake #43163

Open
Neumann-A opened this issue Jan 8, 2025 · 1 comment · May be fixed by #43165
Open

vcpkg_build_make has empty logfile prefix with newer versions of CMake #43163

Neumann-A opened this issue Jan 8, 2025 · 1 comment · May be fixed by #43165
Assignees
@WangWeiLin-MV
Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)

Comments

@Neumann-A
Copy link
Contributor

vcpkg_install_make passes LOGFILE_ROOT without any name which newer CMake versions interpret as empty strings and will define arg_LOGFILE_ROOT to be an empty string. This then leads to logfile names like -<triplet>-etc instead of build-<triplet>-etc
@WangWeiLin-MV WangWeiLin-MV added the category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`) label Jan 8, 2025
@dg0yt
Copy link
Contributor

dg0yt commented Jan 8, 2025

Example (not duplicate): #42957

@WangWeiLin-MV WangWeiLin-MV linked a pull request Jan 8, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:vcpkg-bug The issue is with the vcpkg system (including helper scripts in `scripts/cmake/`)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[scripts/vcpkg_install_make] Keep LOGFILE_ROOT undefined since CMake 3.31.0 WangWeiLin-MV/vcpkg
3 participants
@dg0yt @Neumann-A @WangWeiLin-MV