Debug.Assert failures often leave CI state timing out without additional info on .NET Framework

[Youssef1313]

I'm thinking of banning Debug.Assert, and instead introduce CIDebug.Assert

When building in CI, we can build with some MSBuild property that propagates back to DefineConstants, and DebugOrCI.Assert could be something like this:

internal static class CIDebug
{
#if IS_CI && NETFRAMEWORK
    [Conditional("DEBUG")]
    public static void Assert(...) { if (...) throw ...; }
#else
    [Conditional("DEBUG")]
    public static void Assert(...) => Debug.Assert(...);
#endif
}

@Evangelink thoughts?

[Evangelink]

I think it's already banned to favor using RoslynDebug class to have compiler hinting.

Otherwise LGTM

[Youssef1313]

RoslynDebug appears to be only in Analyzers and Platform

[nohwnd]

are you talking about usage in our code, or general usage like this issue: #3955 ?

[Youssef1313]

@nohwnd Only usages in our code. This is only to make our life easier when an assert fails in CI. So, basically when running in CI and in Debug, we swap Debug.Assert with throw some exception.