Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove override for NativeDOM pointer events casting double to int32_t #14257

Open
jonthysell opened this issue Jan 8, 2025 · 0 comments
Open
Assignees
Milestone

Comments

@jonthysell
Copy link
Contributor

jonthysell commented Jan 8, 2025

Problem Description

In the upstream ReactCommon NativeDOM.cpp there are some implicit casts from doubles to PointerIdentifiers (int32_t) which flag as warnings for us. In the integration we disabled warnings, but that causes BinSkim to complain and fail our builds.

I fixed the issue by creating an override and performing the cast, but this issue should be resolved upstream.

Link to the integration where the error originated

#14092

Link to commit

facebook/react-native@0267ca0

Forked files

ReactCommon\react\nativemodule\dom\NAtiveDOM.cpp

Upstream PR

facebook/react-native#48578

Build Configuration

None

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 8, 2025
@jonthysell jonthysell self-assigned this Jan 9, 2025
@jonthysell jonthysell removed the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jan 9, 2025
@jonthysell jonthysell added this to the 0.78 milestone Jan 9, 2025
@jonthysell jonthysell added the bug label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant