Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Update open systems simulator to use ndarray::linalg::kron. #930

Open
cgranade opened this issue Feb 8, 2022 · 0 comments
Open

Update open systems simulator to use ndarray::linalg::kron. #930

cgranade opened this issue Feb 8, 2022 · 0 comments
Labels
maintenance Improve codebase quality

Comments

@cgranade
Copy link
Contributor

cgranade commented Feb 8, 2022

Please describe what you would like the maintenance work to be.
The open systems simulator uses its own implementation of the flattened tensor product (the Kronecker product), but ndarray has added a new ndarray::linalg::kron function as of 0.15.4. Using that function in favor of our own implementation decreases the API surface that needs to be tested and improves performance.

Additional context
See rust-ndarray/ndarray#1105 for further discussion of the ndarray::linalg::kron feature.

@cgranade cgranade added needs triage An initial review by a maintainer is needed maintenance Improve codebase quality labels Feb 8, 2022
@bettinaheim bettinaheim removed the needs triage An initial review by a maintainer is needed label Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance Improve codebase quality
Projects
None yet
Development

No branches or pull requests

2 participants