From 5c9c52d0d158d2a159425370b1432b1959438bf8 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 31 Jul 2020 17:58:28 +0000 Subject: [PATCH] fix(launcher): extend list of known missing DLLs --- src/server/validateDependencies.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/server/validateDependencies.ts b/src/server/validateDependencies.ts index 90f3bec6f7aa7..d0797a328fa1d 100644 --- a/src/server/validateDependencies.ts +++ b/src/server/validateDependencies.ts @@ -65,9 +65,9 @@ async function validateDependenciesWindows(browserPath: string, browser: Browser let isCrtMissing = false; let isMediaFoundationMissing = false; for (const dep of missingDeps) { - if (dep.startsWith('api-ms-win-crt')) + if (dep.startsWith('api-ms-win-crt') || dep === 'vcruntime140.dll' || dep === 'msvcp140.dll') isCrtMissing = true; - else if (dep === 'mf.dll' || dep === 'mfplat.dll' || dep === 'msmpeg2vdec.dll') + else if (dep === 'mf.dll' || dep === 'mfplat.dll' || dep === 'msmpeg2vdec.dll' || dep === 'evr.dll' || dep === 'avrt.dll') isMediaFoundationMissing = true; } @@ -211,7 +211,7 @@ async function missingFileDependencies(filePath: string): Promise> }); if (code !== 0) return []; - const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim()); + const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim().toLowerCase()); return missingDeps; }