Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverCancelled support for textDocument/documentSymbol #2069

Open
rtetley opened this issue Dec 5, 2024 · 0 comments
Open

Add serverCancelled support for textDocument/documentSymbol #2069

rtetley opened this issue Dec 5, 2024 · 0 comments
Labels
document symbols feature-request Request for new features or functionality
Milestone

Comments

@rtetley
Copy link

rtetley commented Dec 5, 2024

Problem

I am working on developing a language server for the rocq prover, https://github.com/coq/vscoq.
I have recently run into a problem with the document outline (in vscode).
In a recent change, I parse the document incrementally, using events that get popped up in an event loop. Many times the textDocument/documentSymbol request gets sent before the parsing of the document is finished.

Tried solutions

The first solution I explored was using progress based. Unfortunately it seems that vscode does not send a partialResultToken or a workDoneToken in the request although I did opt-in through the capabilities. Maybe there is a subtlety I do not understand ?

The second solution I explored comes from the disccusion in #1367 where it is suggested that after receiving a ServerCancelled error code the client well then re-send the request later. This does not seem to be happening for the documentSymbol request.

After some digging in the spec, it seems documentSymbol is not cancellable ? Compared to the semanticTokensClientCapabilities it does not contain the serverCancelledSupport field.

Proposed solution

Could we add serverCancelled support to the documentSymbol request ?

Related

Related to #1572 and #1367.

Also related to microsoft/vscode#135453

@dbaeumer dbaeumer added feature-request Request for new features or functionality document symbols labels Dec 18, 2024
@dbaeumer dbaeumer added this to the Backlog milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document symbols feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants