Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what supportsCustomValues in the meta model really means #2035

Open
DanTup opened this issue Oct 9, 2024 · 0 comments
Open

Clarify what supportsCustomValues in the meta model really means #2035

DanTup opened this issue Oct 9, 2024 · 0 comments
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Oct 9, 2024

I currently have some custom code that determines whether to accept any value for enums, but since the meta model now has supportsCustomValues I planned to migrate to it.

However, it's not clear to me if this value really means what I thought it meant. I thought it meant that if supportsCustomValues != true then the values passed for this enum can be validated (and we can reject a request as having invalid parameters if it passes values that weren't in the spec we used).

However, the SymbolKind enum does not have "supportsCustomValues": true, yet the client can send a DocumentSymbolClientCapabilities that contains a valueSet saying which symbols the client supports, which presumably in the future could be values that my server did not know about when the validation code was written.

So I don't think I can use this field in the way that I hoped, and that makes me wonder what it really means. If we can't assume that !supportsCustomValues means we can validate those values, what can we actually use this flag for?

@dbaeumer dbaeumer added this to the On Deck milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants