From 9e316ab582f5a7af27278e7698cebf5210d9d214 Mon Sep 17 00:00:00 2001 From: Bill Barnes Date: Mon, 27 Feb 2017 12:20:13 -0800 Subject: [PATCH 1/2] correctly handle webSocket params --- samples/backchannel/index.html | 2 +- samples/standalone/index.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/backchannel/index.html b/samples/backchannel/index.html index a0c597be08..d5bef9ad44 100644 --- a/samples/backchannel/index.html +++ b/samples/backchannel/index.html @@ -65,7 +65,7 @@

Type a color into the WebChat!

secret: params['s'], token: params['t'], domain: params['domain'], - webSocket: params['webSocket'] // defaults to true + webSocket: params['webSocket'] && params['webSocket'] === "true" // defaults to true }); BotChat.App({ diff --git a/samples/standalone/index.html b/samples/standalone/index.html index 68bc7cdced..24327dd0ad 100644 --- a/samples/standalone/index.html +++ b/samples/standalone/index.html @@ -51,7 +51,7 @@ secret: params['s'], token: params['t'], domain: params['domain'], - webSocket: params['webSocket'] // defaults to true + webSocket: params['webSocket'] && params['webSocket'] === "true" // defaults to true }, user: user, bot: bot, From 5ca6c39a2caf90c765ba74422f9e2bbad30abbd6 Mon Sep 17 00:00:00 2001 From: Bill Barnes Date: Mon, 27 Feb 2017 12:21:11 -0800 Subject: [PATCH 2/2] more of the same --- samples/backchannel/index.html | 2 +- samples/standalone/index.html | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/samples/backchannel/index.html b/samples/backchannel/index.html index d5bef9ad44..01725939f0 100644 --- a/samples/backchannel/index.html +++ b/samples/backchannel/index.html @@ -59,7 +59,7 @@

Type a color into the WebChat!

name: params["botname"] || 'botname' }; - window['botchatDebug'] = params['debug']; + window['botchatDebug'] = params['debug'] && params['debug'] === "true"; var botConnection = new BotChat.DirectLine({ secret: params['s'], diff --git a/samples/standalone/index.html b/samples/standalone/index.html index 24327dd0ad..5133bf191b 100644 --- a/samples/standalone/index.html +++ b/samples/standalone/index.html @@ -44,7 +44,7 @@ name: params["botname"] || 'botname' }; - window['botchatDebug'] = params['debug']; + window['botchatDebug'] = params['debug'] && params['debug'] === "true"; BotChat.App({ directLine: {