Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Connect dialog in Web client should allow Enter key to submit form. #358

Open
danditomaso opened this issue Jan 3, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@danditomaso
Copy link
Contributor

danditomaso commented Jan 3, 2025

Hardware

Not Applicable

Connection Type

HTTP

Local or Hosted

https://client.meshtastic.org

Firmware Version

2.5.11.8e2a3e5

Description

The connect dialog on the Meshtastic Web client offers several connection methods, since its a form with a single button it allow the user to press the "Enter" key to submit the form. in order for forms to use their native behaviour (to submit when the enter key is pressed) its important to use a

element with a single element that is a child of the form element and has a type of "submit".

After looking at the code base, it appears to be a bug within the Button element, as everything is correctly set up with the Dialog and Form, but the Button element isn't passing through the "submit" button type correctly.

image image

Relevant console output

No response

@danditomaso danditomaso added the bug Something isn't working label Jan 3, 2025
@danditomaso danditomaso changed the title [Bug]: Connect dialog should allow Enter key to be used to submit Form. [Bug]: Connect dialog in Web client should allow Enter key to submit form. Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant