Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template and asset handling on SecHub jobs #3523

Closed
4 tasks done
Tracked by #3521
de-jcup opened this issue Oct 16, 2024 · 1 comment · Fixed by #3545
Closed
4 tasks done
Tracked by #3521

Template and asset handling on SecHub jobs #3523

de-jcup opened this issue Oct 16, 2024 · 1 comment · Fixed by #3545
Assignees
@de-jcup
Milestone
Server 2.4.0

Comments

@de-jcup
Copy link
Member

de-jcup commented Oct 16, 2024 •
edited
Loading

Wanted

SecHub template and asset handling on starting jobs

  • introduce template data resolver in commons (for SecHub server, PDS side and also wrpapers)
  • create and add PDS parameter pds.config.template.metadata.list which contains information
    about assets for template types and also variable data
  • an integration ensures that the PDS will receive pds.config.template.metadata.list parameter
  • ensure asset available for PDS jobs
    (upload in asset storage if not already there, or if checksum is not as expected -
    as a fallback for a db restore or storage problems)
@de-jcup de-jcup self-assigned this Oct 16, 2024
This was referenced Oct 16, 2024
Open
Merged
de-jcup added a commit that referenced this issue Nov 14, 2024
@de-jcup
SecHub PDS communication parts for assets and templates #3523
cdfa471 
- it is now ensured on every pds job call, that the assets in storage
  are same as in db. Same logic for admin create/update operation is
  used.
- improved PDSWebScanJobScenario12IntTest which does now uses templates
  and assets. The test ensures that the PDS instance will receive
  the pds template meta data.
- changed templateDefinition format. Assets now no longer an array
  but only one entry. Means we have 1:n relation here from
  asset to templates and no longer m:n.
- added unit tests
- introduced TemplateData resolver in commons-model which can be
  used from PDS and wrapper applications
- introduced TemplateData inside SecHub convfiguration file
@de-jcup
Copy link
Member Author

de-jcup commented Nov 14, 2024

The #3610 will validate user input at job creation time. We do not additionally validate here.

de-jcup added a commit that referenced this issue Nov 15, 2024
@de-jcup
SecHub PDS communication parts for assets and templates #3523
4b7af4c 
- it is now ensured on every pds job call, that the assets in storage
  are same as in db. Same logic for admin create/update operation is
  used.
- improved PDSWebScanJobScenario12IntTest which does now uses templates
  and assets. The test ensures that the PDS instance will receive
  the pds template meta data.
- changed templateDefinition format. Assets now no longer an array
  but only one entry. Means we have 1:n relation here from
  asset to templates and no longer m:n.
- added unit tests
- introduced TemplateData resolver in commons-model which can be
  used from PDS and wrapper applications
- introduced TemplateData inside SecHub convfiguration file
- Template and Asset REST controller are now annotated with profile
  admin access
de-jcup added a commit that referenced this issue Nov 15, 2024
@de-jcup
SecHub PDS communication parts for assets and templates #3523
5c13f87 
- it is now ensured on every pds job call, that the assets in storage
  are same as in db. Same logic for admin create/update operation is
  used.
- improved PDSWebScanJobScenario12IntTest which does now uses templates
  and assets. The test ensures that the PDS instance will receive
  the pds template meta data.
- changed templateDefinition format. Assets now no longer an array
  but only one entry. Means we have 1:n relation here from
  asset to templates and no longer m:n.
- added unit tests
- introduced TemplateData resolver in commons-model which can be
  used from PDS and wrapper applications
- introduced TemplateData inside SecHub convfiguration file
- Template and Asset REST controller are now annotated with profile
  admin access
de-jcup added a commit that referenced this issue Nov 15, 2024
@de-jcup
SecHub PDS communication parts for assets and templates #3523
e346ecf 
- it is now ensured on every pds job call, that the assets in storage
  are same as in db. Same logic for admin create/update operation is
  used.
- improved PDSWebScanJobScenario12IntTest which does now uses templates
  and assets. The test ensures that the PDS instance will receive
  the pds template meta data.
- changed templateDefinition format. Assets now no longer an array
  but only one entry. Means we have 1:n relation here from
  asset to templates and no longer m:n.
- added unit tests
- introduced TemplateData resolver in commons-model which can be
  used from PDS and wrapper applications
- introduced TemplateData inside SecHub convfiguration file
- Template and Asset REST controller are now annotated with profile
  admin access
de-jcup added a commit that referenced this issue Nov 15, 2024
@de-jcup
Made flaky integration test TemplateScenario1IntTest stable #3523
550b0b5 
- introduced TestAPI.executeResilient which is a short term for
  executeRunnableAndAcceptAssertionsMaximumTimes(4, runnable, 500);
- all time relevant parts inside integration test
  TemplateScenario1IntTest do now use this for testing
@de-jcup de-jcup added this to the Server 2.4.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
None yet
Projects
None yet
Milestone
Server 2.4.0
Development

Successfully merging a pull request may close this issue.

Provide templates and assets mercedes-benz/sechub
1 participant
@de-jcup