Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangouts conversations doesn't show contact's name for sms conversations #5

Open
MichaelCampbell opened this issue Nov 28, 2017 · 4 comments

Comments

@MichaelCampbell
Copy link

As a project Fi user, you are able to send and receive SMS / MMS through Hangouts.

Expected Behavior

The contact names appear next to conversations that are either SMS / MMS or Hangouts. When visiting hangouts.google.com directly in Chrome or Safari, the contact names appear for sms conversations.

Current Behavior

In Franz, the contact names are missing for every SMS conversation, but appear for every hangouts conversation.

Steps to Reproduce (for bugs)

View Hangouts in Franz

Your Environment

macOS Sierra. Version 10.12.6

@MichaelCampbell
Copy link
Author

@cebertowicz
Copy link

+1

@brucerpdx
Copy link

+1 and I think it would affect people with Google Voice as well. @adlk has GV, maybe he can confirm? Here's his issue ticket: #1

@heavypackets
Copy link

Opening up the developer console and I saw the following exceptions:

screenshot 2017-12-21 10 13 21

This seems to occur because Google Hangouts itself is using iframes, and the nesting of iframes is breaking how it looks up DOM elements.

In the network console you can also see a call to Google API that is failing:

https://clients6.google.com/voice/v1/users/@me/account?checkHangoutsCallingPermission=false&key=#################&locale=en-US&alt=protojson

{ "error": { "errors": [ { "domain": "global", "reason": "authError", "message": "Invalid Credentials", "locationType": "header", "location": "Authorization" } ], "code": 401, "message": "Invalid Credentials" } }

The response is always a 401. There's an 'x-frame-options: SAMEORIGIN' set in the response header, which lead me to be believe the call is failing because of the nested iframes causing security issues.

A similar project to Franz experienced the same issue: https://github.com/saenzramiro/rambox/issues/406

I looked up the potential fix and it's due to web security being disabled in the WebView settings for the apps embedded browser windows. Long story short, this actually appears to be an issue with how Franz is using the WebView control itself, not this recipe. I'm currently working on a patch for Franz and will update https://github.com/meetfranz/franz/issues/30 if I can get it working without any regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants