Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching through the source code #2

Open
Rob--W opened this issue May 14, 2016 · 3 comments
Open

Searching through the source code #2

Rob--W opened this issue May 14, 2016 · 3 comments

Comments

@Rob--W
Copy link

Rob--W commented May 14, 2016

Could you index extensions by manifest keys (e.g. permissions / optional_permissions, content_scripts), and add the ability to search through the source code of extensions that match the query?

For example, I'd like to know how many extensions use the webRequest API in a blocking fashion (=webRequest + webRequestBlocking permissions) and block "ping" requests (to make informed decisions on https://crbug.com/611453).
@mdamien
Copy link
Owner

mdamien commented May 14, 2016

Yes, that's really the next step (full source code search + metadata search).

I'm currently indexing extensions infos + metadata to elasticsearch, source code search should come soon after that.

mdamien added a commit that referenced this issue May 15, 2016
@mdamien
first take at #2 (search code base) via elastic search
ad2ec51 
Now I wonder mainly if I should do it in mariadb/postgres instead
since we want precise search and fuzzy searchs are not that useful
here

Also, I was hoping that using ES would make search efficient like
with Algolia but it's hard to tune the thing
@mdamien
Copy link
Owner

mdamien commented May 20, 2016 •
edited
Loading

Reminder to myself: just extract the archives and do a normal recursive file search
http://beyondgrep.com/more-tools/ for efficient search

@mdamien
Copy link
Owner

mdamien commented May 20, 2016 •
edited
Loading

Here's a very basic prototype using ag: http://codesearch.x.dam.io/?q=your_thing

EDIT: now switching to another strategy and doing it with postgres instead

mdamien added a commit that referenced this issue May 20, 2016
@mdamien
add basic search server for #2
2b93a87
@mdamien mdamien mentioned this issue Jul 1, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rob--W @mdamien