Skip to content
This repository has been archived by the owner on Aug 24, 2022. It is now read-only.

synapse not restarted on upgrade #18

Closed
richvdh opened this issue Aug 18, 2017 · 8 comments
Closed

synapse not restarted on upgrade #18

richvdh opened this issue Aug 18, 2017 · 8 comments

Comments

@richvdh
Copy link
Member

richvdh commented Aug 18, 2017

which is ... surprising. It appears to be because of the '--no-start' at https://github.com/matrix-org/package-synapse-debian/blob/debian/debian/rules#L15.

What's the reasoning here? If it's just to avoid running the server until someone has configured it, we should do that by adding an ENABLED setting to the default file, or similar

@richvdh richvdh changed the title "synapse not restarted on upgrade" "which is ... surprising. It appears to be because of the '--no-start' at https://github.com/matrix-org/package-synapse-debian/blob/debian/debian/rules#L15. What's the reasoning here? If it's just to avoid running the server until someone has configured it, we should do that by adding an ENABLED setting to the default file, or similar synapse not restarted on upgrade Aug 18, 2017
@andrewshadura
Copy link

This has been fixed in the Debian package, which PR #24 will have merged back.

@erdnaxeli
Copy link

Is it fixed now?

@richvdh
Copy link
Member Author

richvdh commented Aug 10, 2018

not afaik, no. If anyone could take the time to pull the relevant bits out of the epic #24 PR then that would help.

@andrewshadura
Copy link

If matrix-org/synapse#1932 ever gets fixed, this repository can be rebased on top of the Debian branch or completely replaced by it, and then the issue will be solved automagically :)

@richvdh
Copy link
Member Author

richvdh commented Aug 13, 2018

What's the reasoning here? If it's just to avoid running the server until someone has configured it, we should do that by adding an ENABLED setting to the default file, or similar

https://www.debian.org/doc/debian-policy/ch-opersys.html#managing-the-links has some words on the correct way to do that, fwiw, though it suggests using init-system-helpers (>= 1.50), which is no good because it only landed in buster.

@maxidorius
Copy link

maxidorius commented Oct 22, 2018

synapse is not started on a fresh install either. synapse is actually never started after the package is deployed, regardless of the situation.

@richvdh
Copy link
Member Author

richvdh commented Dec 13, 2018

It may be worth noting that the default configuration of the package does enable it in systemd, so it will be started on boot. If anything, that makes the decision to not have it automatically start on installation/upgrade even stranger.

@richvdh
Copy link
Member Author

richvdh commented Jan 23, 2019

this got fixed in matrix-synapse-py3 (and is fixed in matrix-synapse in downstream debian iirc)

@richvdh richvdh closed this as completed Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants