From 1b8f4e22b61196ce37dee0b230ae2c173aaa6676 Mon Sep 17 00:00:00 2001 From: Alexandre Franke Date: Mon, 31 May 2021 15:17:45 +0200 Subject: [PATCH 1/4] Add per room spell check language MSC --- .../3225-per-room-spellcheck-language.md | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 proposals/3225-per-room-spellcheck-language.md diff --git a/proposals/3225-per-room-spellcheck-language.md b/proposals/3225-per-room-spellcheck-language.md new file mode 100644 index 00000000000..9d96c1489b9 --- /dev/null +++ b/proposals/3225-per-room-spellcheck-language.md @@ -0,0 +1,42 @@ +# MSC3225: Per Room Spellcheck Language + +It is common for people on the Internet to talk in more than one language. English will probably be +the most used one, but for many it is not their mother tongue and they will use the latter as well. + +Clients can offer spell checking functionality, but in order to provide helpful suggestions they need +to know which language the user is currently writing in. When spell checking is available, the language +can usually be selected e.g. via the right click menu, but it becomes tedious when one switches back and +forth between two or more of them. + +This proposal aims at providing users with a way to set a language per room, so that switching between +conversations held in different languages automatically switches to the appropriate dictionary. + + +## Proposal + +Clients offering spell checking should default their dictionary to the system language. They should offer +a way to change it and when the user sets a specific language, then they should store the language code +as `m.input_language` account data for the room where it was set. Language codes must be +[RFC3066](https://datatracker.ietf.org/doc/html/rfc3066) compliant. + + +## Alternatives + +The language could be defined as a room property: a room administrator could set it once and then every +member would get it for free. However, not everyone in a given room necessarily talks in the same language +(or even language variant, e.g. en_US vs en_GB) and there would need to be a way for users to override the +room property. This MSC could be used as a mechanism to do said override, if such a room property were ever +defined. Adding a room property requires more work and thought, and can be done in another MSC. It is thus +considered out of scope for this one. + +The feature can also work without actually adding it to the Matrix specification. There is indeed already +one existing implementation (see [Unstable prefix](#unstable-prefix) below). Standardising the account data +type though has the benefit that it is not client specific anymore, and the setting can be more easily reused +by any number of clients. + + +## Unstable prefix + +Fractal already successfully offers this proposed feature. It stores the language code under the +`org.gnome.fractal.language` account data type. This was released on the stable channel as part of +Fractal 4.4 on August 7th 2020. From 70192e8e1143ea3450db001b78b05039a3ef58b1 Mon Sep 17 00:00:00 2001 From: Alexandre Franke Date: Mon, 31 May 2021 16:33:40 +0200 Subject: [PATCH 2/4] Fix MSC number --- ...llcheck-language.md => 3226-per-room-spellcheck-language.md} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename proposals/{3225-per-room-spellcheck-language.md => 3226-per-room-spellcheck-language.md} (98%) diff --git a/proposals/3225-per-room-spellcheck-language.md b/proposals/3226-per-room-spellcheck-language.md similarity index 98% rename from proposals/3225-per-room-spellcheck-language.md rename to proposals/3226-per-room-spellcheck-language.md index 9d96c1489b9..72a9343b1b0 100644 --- a/proposals/3225-per-room-spellcheck-language.md +++ b/proposals/3226-per-room-spellcheck-language.md @@ -1,4 +1,4 @@ -# MSC3225: Per Room Spellcheck Language +# MSC3226: Per Room Spellcheck Language It is common for people on the Internet to talk in more than one language. English will probably be the most used one, but for many it is not their mother tongue and they will use the latter as well. From 841bdf5ea65aba17c6d6eb32dbd7f9eb43368ed8 Mon Sep 17 00:00:00 2001 From: Alexandre Franke Date: Mon, 30 Aug 2021 15:18:23 +0200 Subject: [PATCH 3/4] Revert per room spell check language MSC This reverts commit 70192e8e1143ea3450db001b78b05039a3ef58b1. This reverts commit 1b8f4e22b61196ce37dee0b230ae2c173aaa6676. --- .../3226-per-room-spellcheck-language.md | 42 ------------------- 1 file changed, 42 deletions(-) delete mode 100644 proposals/3226-per-room-spellcheck-language.md diff --git a/proposals/3226-per-room-spellcheck-language.md b/proposals/3226-per-room-spellcheck-language.md deleted file mode 100644 index 72a9343b1b0..00000000000 --- a/proposals/3226-per-room-spellcheck-language.md +++ /dev/null @@ -1,42 +0,0 @@ -# MSC3226: Per Room Spellcheck Language - -It is common for people on the Internet to talk in more than one language. English will probably be -the most used one, but for many it is not their mother tongue and they will use the latter as well. - -Clients can offer spell checking functionality, but in order to provide helpful suggestions they need -to know which language the user is currently writing in. When spell checking is available, the language -can usually be selected e.g. via the right click menu, but it becomes tedious when one switches back and -forth between two or more of them. - -This proposal aims at providing users with a way to set a language per room, so that switching between -conversations held in different languages automatically switches to the appropriate dictionary. - - -## Proposal - -Clients offering spell checking should default their dictionary to the system language. They should offer -a way to change it and when the user sets a specific language, then they should store the language code -as `m.input_language` account data for the room where it was set. Language codes must be -[RFC3066](https://datatracker.ietf.org/doc/html/rfc3066) compliant. - - -## Alternatives - -The language could be defined as a room property: a room administrator could set it once and then every -member would get it for free. However, not everyone in a given room necessarily talks in the same language -(or even language variant, e.g. en_US vs en_GB) and there would need to be a way for users to override the -room property. This MSC could be used as a mechanism to do said override, if such a room property were ever -defined. Adding a room property requires more work and thought, and can be done in another MSC. It is thus -considered out of scope for this one. - -The feature can also work without actually adding it to the Matrix specification. There is indeed already -one existing implementation (see [Unstable prefix](#unstable-prefix) below). Standardising the account data -type though has the benefit that it is not client specific anymore, and the setting can be more easily reused -by any number of clients. - - -## Unstable prefix - -Fractal already successfully offers this proposed feature. It stores the language code under the -`org.gnome.fractal.language` account data type. This was released on the stable channel as part of -Fractal 4.4 on August 7th 2020. From e895827731bd5cd17fdc23f135602937e4f0d009 Mon Sep 17 00:00:00 2001 From: Sorunome Date: Mon, 30 Aug 2021 16:24:33 +0200 Subject: [PATCH 4/4] MSC2582: Remove mimetype from EncryptedFile object (#2582) * add proposal * Update proposals/2582-remove-mimetype-from-encrypted-file.md Co-authored-by: Hubert Chathi * Update proposals/2582-remove-mimetype-from-encrypted-file.md Co-authored-by: Hubert Chathi Co-authored-by: Hubert Chathi --- .../2582-remove-mimetype-from-encrypted-file.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 proposals/2582-remove-mimetype-from-encrypted-file.md diff --git a/proposals/2582-remove-mimetype-from-encrypted-file.md b/proposals/2582-remove-mimetype-from-encrypted-file.md new file mode 100644 index 00000000000..3b1f83c7a06 --- /dev/null +++ b/proposals/2582-remove-mimetype-from-encrypted-file.md @@ -0,0 +1,12 @@ +# Remove `mimetype` from `EncryptedFile` object + + +## Proposal +The example in the spec currently lists `mimetype` in the [examples for `EncryptedFile`](https://matrix.org/docs/spec/client_server/r0.6.1#extensions-to-m-message-msgtypes) but not in +the object definition. As that is duplicate information of the `info` block of file events, the +mimetype should just be removed alltogether. + + +## Potential issues +Some clients might depend on this. However, as of August 2021, all known clients have +been confirmed to not use this.