MatrixEvent.getOriginalContent seems to be lying about types, hindering threading in some clients

[filipesmedeiros]

According to some investigation done in cinnyapp/cinny#2047, MatrixEvent.getOriginalContent seems to be lying about the type of the returned content, more specifically when it returns an IClearEvent but says it returns an IContent (I think, please forgive any mistakes).

This seems to be leading to some clients (or at least Cinny) to be unable to properly thread messages, because they fail to understand when a message is threaded or not.

There are more details in the issue linked above, but I can give more information if needed.

Thanks!

[t3chguy]

As you can see by the code, it does not return IClearEvent, it returns IClearEvent["content"] which is a subset of IContent - given IContent has all of its fields optional they are exchangeable like this

[t3chguy]

The content types are awfully weak due to lack of runtime type checking against what comes down from the server.

The right method to use for Cinny would be getRelation or as that method does, getWireContent

Closing as a downstream issue using the wrong method.

The IClearEvent interface explicitly excludes m.relates_to so expecting to have the relationship is asking for trouble

[filipesmedeiros]

Thanks for the quick help!