Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Support for undefined licenses in dependencies #241

Open
VenaNocta opened this issue Oct 28, 2021 · 1 comment
Open

Filter Support for undefined licenses in dependencies #241

VenaNocta opened this issue Oct 28, 2021 · 1 comment
Assignees
Labels
in:core MLP core module is:bug Bugs to fix todo Accepted items from the backlog which can be worked on

Comments

@VenaNocta
Copy link

Currently if a dependency doesn't have an license defined it prints just an error-code and omitts that there are some unknown dependency-licenses.

[INFO] ------------------< net.runeduniverse.libs.rogm:core >------------------
[INFO] Building ROGM Core 2.1.1                                           [2/6]
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- license-maven-plugin:4.2.rc1:check (default-cli) @ core ---
[INFO] Checking licenses...
[INFO] Checking licenses in dependencies using class com.mycila.maven.plugin.license.dependencies.MavenProjectLicenses
[INFO] Discovered dependencies after filtering: 5
[WARNING] Could not get project from dependency's artifact: null
[WARNING] Could not get project from dependency's artifact: null
[WARNING] Could not get project from dependency's artifact: null
[WARNING] Could not get project from dependency's artifact: null

Request:

applyable when <dependencyEnforce>true</dependencyEnforce>

  • provide a filter for undefined licenses to APPROVE or DENY them
  • don't skip execution of ARTIFACT_PATTERN filter
@mathieucarbou mathieucarbou added in:core MLP core module is:bug Bugs to fix todo Accepted items from the backlog which can be worked on labels Nov 26, 2021
@mathieucarbou
Copy link
Owner

@rremer : could you please have a quick look ? I suspect this is caused by the introduction of the dependency enforer plugin ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:core MLP core module is:bug Bugs to fix todo Accepted items from the backlog which can be worked on
Projects
None yet
Development

No branches or pull requests

3 participants