Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New feature request] Disable print complete notification #208

Open
dimateos opened this issue Dec 14, 2022 · 2 comments
Open

[New feature request] Disable print complete notification #208

dimateos opened this issue Dec 14, 2022 · 2 comments
Assignees

Comments

@dimateos
Copy link

I would love a silent mode. I basically have a pdf viewer opened that refreshes the file changed from disk, so the notification is reduntant and a bit annoying (I have to manually close it?).

Anyway thanks for the great extension! It's great to be able to use the system parser and get the same output as the preview :)

@manuth manuth self-assigned this Dec 14, 2022
@manuth manuth added this to the Major Release October 2022 milestone Dec 14, 2022
@manuth
Copy link
Owner

manuth commented Dec 14, 2022

Oh this sounds very easy to implement 😄
Personally, I guess it might be a good idea to have an option such as markdownConverter.Notifications which can be set to false, true (default) or a set of message IDs to show. I imagine it like this:

Examples:

{
    "markdownConverter.notifications": true
}
{
    "markdownConverter.notifications": false
}
{
    "markdownConverter.notifications": {
        "default": false,
        "conversionFinished": true
    }
}
{
    "markdownConverter.notifications": {
        "default": true,
        "sslError": false
    }
}

What are your thoughts?

@dimateos
Copy link
Author

Yeah absolutely! I was only thinking about disabling the conversion finished one. But seems good to add granularity to be able to keep notifications for error logs. So my guess would be either:

  1. Keep it simple and only disable notifications for conversionFinished while keeping the errors. Do not allow the user to remove them. This good be good enough for me.
  2. As you suggested with your 2 last examples: option per type of notification. Allow the user to remove any/all. This is also easier to extend to more features that you could add in the future.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants