Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeprecationWarnings for Numpy (1.25.0 and 2.0) #2289

Closed
MikeSullivan7 opened this issue Jul 23, 2024 · 0 comments · Fixed by #2290
Closed

Fix DeprecationWarnings for Numpy (1.25.0 and 2.0) #2289

MikeSullivan7 opened this issue Jul 23, 2024 · 0 comments · Fixed by #2290
Assignees
@MikeSullivan7
Labels
cleanup Type: Improvement

Comments

@MikeSullivan7
Copy link
Collaborator

MikeSullivan7 commented Jul 23, 2024 •
edited
Loading

Desired Behaviour

No DeprecationWarnings how when we run tests or during runtime.

Current Behaviour

From PR #2280, we now get DeprecationWarnings for Numpy, an example is given below:

mantidimaging/core/io/test/io_test.py: 172 warnings
mantidimaging/gui/windows/nexus_load_dialog/test/presenter_test.py: 4 warnings
  C:\Users\ddb29996\AppData\Local\miniforge3\envs\mantidimaging-dev\lib\site-packages\h5py\_hl\attrs.py:103: DeprecationWarning: `product` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `prod` instead.
    self.create(name, data=value)

NOTE: Some of these warnings may be due to our dependencies rather than from MI code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSullivan7 MikeSullivan7

Labels
cleanup Type: Improvement
Projects
Mantid Imaging Work
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix numpy deprecation warnings mantidproject/mantidimaging
1 participant
@MikeSullivan7