Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polarized SANS metadata: apply user file settings in SANS reduction save #38525

Open
rbauststfc opened this issue Dec 18, 2024 · 0 comments
Open
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Milestone

Comments

@rbauststfc
Copy link
Contributor

rbauststfc commented Dec 18, 2024

Part of #36147. See the design and requirements documents, and the NXcanSAS specification proposal, that are linked on that issue for more details of what needs to be implemented.

In the SANS reduction workflow, we need to the use the polarized SANS settings that we have stored in the state object to do the following:

  • If required, overwrite parameter values and/or move the location of relevant polarizing components in the IDF.
  • If under Polarized SANS metadata: add user file definition and ability to parse inputs #38524 we have decided not to handle this in the user file parser, we will need to load any efficiency, transmission or empty cell data that has been provided by file.
  • Pass relevant metadata from the state object to relevant properties of the SANSSave algorithm. The SANSSave algorithm will also need to start accepting a workspace group/workspace list.
  • I think we will need to refactor/extend the save workflow in the reduction slightly, because at the moment it looks like the code loops through a list of workspace names and saves them individually. For polarised reductions we will want to save multiple workspaces into the same file, so we will need a pathway that does this.

We will need to ensure the following:

  • We don't break the Save Other button functionality in the SANS GUI. Most of the reduction code and integrated save workflow is common to both the GUI and the command interface. It's out of scope to support saving polarized SANS metadata via the GUI at this stage (this includes via the Save Other button in the GUI), but we obviously need to make sure that changes we make do not have any negative consequences for the GUI reduction.
  • That the save works correctly when performing a reduction via a script using the ISIS SANS command interface.

This issue should not be worked on until #38524 has been completed.

@rbauststfc rbauststfc added SANS Issues and pull requests related to SANS ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Dec 18, 2024
@rbauststfc rbauststfc added this to the Release 6.13 milestone Dec 18, 2024
@rbauststfc rbauststfc moved this from New to Backlog in ISIS LSS Sprint Planning Dec 18, 2024
@rbauststfc rbauststfc moved this to Gathering Requirements in ISIS Polarised SANS Reduction Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
Status: Backlog
Status: Gathering Requirements
Development

No branches or pull requests

1 participant